1184802 - Remove vestigial uses of mozRequestAnimationFrame from gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Boris Zbarsky [:bzbarsky]]

There's no reason for them.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Oleg, please let me know if someone else should review this?

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8635066 [details]
Fix

Hey Boris!

I'd usually hand over such general Gaia things to :kgrandon :) Otherwise you can use [1] to find appropriate Gaia app owner/peer (for the clock app it would be :millermedeiros, but I'm sure there is not much to review here).

Thanks!

[1] https://wiki.mozilla.org/Modules/All#Submodules_of_Gaia

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8635066 [details]
Fix

A gaia owner like Tim or Vivien is probably the right person to review this if you want a single reviewer - this code looks simple enough though that I'm going to be a bit loose with the rules and mark an R+ to save on review cycles. Thank you for the patch!

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8635066 [details]
Fix

Just FYI - on the try run it looks like a keyboard test is failing[1]. This is really strange to me, but it looks like we're actually testing the "size" of the app? I'm not sure why we would have a test like this, as it seems you would have to zip, and update that number on every change.

I'm forwarding this review over to Tim who knows keyboard, and might be able to shed some insight on this.

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=62889e319b64428967f2f0fc1da6cad0301ac661

Comment 6

[Boris Zbarsky [:bzbarsky]]

Kevin, thanks!  "Tim or Vivien" is the info I really needed here; most of my gaia changes are likely to cross apps like this one.  ;)

The simple thing to do with keyboard may be to drop the changes to it, since those are in libraries anyway... but I'll see what Tim thinks.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8635066 [details]
Fix

That's because the build script indeed need to count the size of each of the layouts. I agree it's annoying to be honest, but I have not have a chance to modify the assertion yet...

You could leave this bug to me and I can merge the patch once someone fix that.

Comment 8

[Boris Zbarsky [:bzbarsky]]

That sounds lovely!

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] timdream:keyboard-build-test-remove-size-check2 > mozilla-b2g:master

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/66fa0bcaa6bc6a8785e6e13dcde5d992627338ca