[Settings] Support new MozMobileMessage.getSmscAddress() function

RESOLVED FIXED in Firefox OS master

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: freesamael, Assigned: freesamael)

Tracking

unspecified
2.1 S1 (1aug)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-master fixed)

Details

Attachments

(1 attachment)

The return type of MozMobileMessage.getSmscAddress() will be changed to Promise<SmscAddress> in Bug 1043250. Gaia should be able to support both Promise and legacy DOMRequest interfaces by adapting DOMRequest.then().
Blocks: 1043250
Created attachment 8635912 [details] [review]
[gaia] freesamael:bz/1184869-on-2f36e9c > mozilla-b2g:master
Assignee: nobody → sawang
Comment on attachment 8635912 [details] [review]
[gaia] freesamael:bz/1184869-on-2f36e9c > mozilla-b2g:master

Hi Evelyn,

The original interface of MozMobileMessage.getSmscAddress() resolves to a string consisting of whatever the underlying modem returns.

Gaia assumes the return value to be in text mode, but some devices report SMSC in PDU mode and cause the displayed SMSC address in Settings becomes unreadable on those devices.

To resolve this problem, in Bug 1043250 we're change the interface from

> DOMRequest getSmscAddress(optional unsigned long serviceId);

to

> Promise<SmscAddress> getSmscAddress(optional unsigned long serviceId);

The Gaia part has to be updated as well in order to support both implementations. Could you help to review the patch I made in Gaia for this purpose, or give me some feedbacks on it?
Attachment #8635912 - Flags: review?(ehung)

Comment 3

3 years ago
Comment on attachment 8635912 [details] [review]
[gaia] freesamael:bz/1184869-on-2f36e9c > mozilla-b2g:master

r+ with nit addressed. Thanks.
Attachment #8635912 - Flags: review?(ehung) → review+
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/b5f1d448f17e9a8a920d40d169eba12cfac2d0c5
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-master: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
You need to log in before you can comment on or make changes to this bug.