1184936 - [e10s] Printing with "Print To File" fails, if Ubuntu system language is set to non English language

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Alice0775 White]

Similar to Bug 1156742, but this is on Linux.

This problem is occurred on only e10s.

Steps to reproduce
1. Enable e10s
2. File > Print and then select "Print To File"

Actual Results:
No file is created. Printing is silently failed

Expected Results
pdf or postscript file shpuld be created

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Print to XPS isn't silently failing, but gives "no permission to save the file in this location" or some such.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Milan Sreckovic [:milan] from comment #1)
> Print to XPS isn't silently failing, but gives "no permission to save the
> file in this location" or some such.

Never mind, this is https://bugzilla.mozilla.org/show_bug.cgi?id=1156742

Comment 3

[Adrian Florinescu [:aflorinescu]]

Based on Comment2 marking issue as duplicate.

Comment 4

[Bob Owen (:bobowen)]

(In reply to Adrian Florinescu [:AdrianSV] from comment #3)
> Based on Comment2 marking issue as duplicate.
> 
> *** This bug has been marked as a duplicate of bug 1156742 ***

I think Milan was just saying that what he was seeing was bug 1156742.

This bug however was reported for Linux and so is not a duplicate of 1156742.

Comment 5

[Adrian Florinescu [:aflorinescu]]

Yup, apologies for the mistake. Only after submitting the change I noticed the mistake.

However I can  confirm on Aurora46, print to file behaves as expected.
(Version 46.0a2 Build ID	20160205004003 User Agent Mozilla/5.0 (X11; Linux i686; rv:46.0)

Comment 6

[Bob Owen (:bobowen)]

(In reply to Adrian Florinescu [:AdrianSV] from comment #5)
> Yup, apologies for the mistake. Only after submitting the change I noticed
> the mistake.
> 
> However I can  confirm on Aurora46, print to file behaves as expected.
> (Version 46.0a2 Build ID	20160205004003 User Agent Mozilla/5.0 (X11; Linux
> i686; rv:46.0)

No problem, thanks for testing.

Alice - can you still reproduce this?

Comment 7

[Alice0775 White]

Nightly47.0a1 works as expected.

Comment 8

[Alice0775 White]

Oops, 
On Ubuntu, It still reproducible on Nightly47.0a1.

Comment 9

[Adrian Florinescu [:aflorinescu]]

Version 47.0a1 Build ID 20160205030204 User Agent Mozilla/5.0 (X11; Linux i686; rv:47.0) Gecko/20100101 
Alice, it works for me on 47 as well, are the STR from the user story complete?

Comment 10

[Adrian Florinescu [:aflorinescu]]

Forgot to mention, the OS is Ubuntu 14.04.

Comment 11

[Alice0775 White]

(In reply to Adrian Florinescu [:AdrianSV] from comment #9)
> Version 47.0a1 Build ID 20160205030204 User Agent Mozilla/5.0 (X11; Linux
> i686; rv:47.0) Gecko/20100101 
> Alice, it works for me on 47 as well, are the STR from the user story
> complete?

On Nightly47.0a1 Ubuntu14.04LTS 32bit

STR
1. "System Tools" > "System Setting" > "Language Support"
    Select "日本語"(Japanese) > click "Apply System-Wide" and close
2. Re-login

3. Start Nightly47.01 with Enabled e10s profile
4. Open Webpage (e.g https://addons.mozilla.org/en-US/firefox/?utm_source=snippet&utm_medium=snippet&utm_campaign=addons )
5. File > Print 
6. Select "Print To File"
7. Make sure, File: ~/desktop/aaaaa.pdf
8. Click "Print"

Actual Results:
No thing is created.

Expected Results:
aaaaa.pdf should be created on desktop.
Disable e10s fixes the problem.

***Strange thing***, if Ubuntu system language is "English" at Step1 fixes the problem.

Comment 12

[Adrian Florinescu [:aflorinescu]]

Thanks Alice for the STR update.
I have reproduced the issue as well on 47Nightly when the system language was set to JP. 
I also did some additional tests and the conclusion i reached is that this behavior is not only JP related, but it reproduces on any language. I got the same malfunction when i set the language to Chinese or Romanian, so my assumption is that no matter what language you set, the print to file will fail.

Also I can confirm that when you set it back to english, print to file works w/o problems.

Note: The build used is the standard Nightly build and not an l10n.

Comment 13

[Makoto Kato [:m_kato]]

Ikeda-san, although I have a fix, could you handle this?

Comment 14

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1184936 - Need convert from UTF8 for printer name. r?karlt

Review commit: https://reviewboard.mozilla.org/r/34131/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34131/

Comment 15

[Karl Tomlinson (:karlt)]

Comment on attachment 8717319 [details]
MozReview Request: Bug 1184936 - Need convert from UTF8 for printer name. r?karlt

https://reviewboard.mozilla.org/r/34131/#review30829

Thank you!

::: widget/gtk/nsPrintSettingsGTK.cpp:483
(Diff revision 1)
> -  *aPrinter = ToNewUnicode(nsDependentCString(gtkPrintName));
> +  *aPrinter = ToNewUnicode(NS_ConvertUTF8toUTF16(gtkPrintName));

*aPrinter = UTF8ToNewUnicode(nsDependentCString(gtkPrintName));

to save buffer copying and maybe an allocation.

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5f6e1f0e0e8

Comment 17

[Sotaro Ikeda [:sotaro]]

(In reply to Makoto Kato [:m_kato] from comment #13)
> Ikeda-san, although I have a fix, could you handle this?

Kato-san, thanks a lot for taking the bug!

Comment 18

[Mike Conley (:mconley) (:⚙️)]

Yes, thank you!

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a5f6e1f0e0e8

Comment 20

[Liz Henry (:lizzard) (relman/hg->git project)]

Want to uplift this to aurora? It would be nice for printing to work on release for Ubuntu users

Comment 21

[Makoto Kato [:m_kato]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #20)
> Want to uplift this to aurora? It would be nice for printing to work on
> release for Ubuntu users

When Firefox 46 turns on e10s, this is nice that users use non-ASCII printer name on Linux.

Comment 22

[Makoto Kato [:m_kato]]

Comment on attachment 8717319 [details]
MozReview Request: Bug 1184936 - Need convert from UTF8 for printer name. r?karlt

Approval Request Comment
[Feature/regressing bug #]:
No

[User impact if declined]:
If printer name has non-ASCII character and users use e10s, Firefox for Linux cannot print web page by it.

[Describe test coverage new/current, TreeHerder]:
Landed in m-c

[Risks and why]:
No.  Because convert string to correct name

[String/UUID change made/needed]:
No

Comment 23

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8717319 [details]
MozReview Request: Bug 1184936 - Need convert from UTF8 for printer name. r?karlt

Fix for e10s printing regression, ok to uplift to aurora.

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3f09847e89d1