Closed Bug 1184936 Opened 5 years ago Closed 4 years ago

[e10s] Printing with "Print To File" fails, if Ubuntu system language is set to non English language

Categories

(Core :: Widget: Gtk, defect, P2)

42 Branch
Unspecified
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
e10s + ---
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: alice0775, Assigned: m_kato)

Details

(Keywords: jp-critical)

Attachments

(1 file)

Similar to Bug 1156742, but this is on Linux.

This problem is occurred on only e10s.

Steps to reproduce
1. Enable e10s
2. File > Print and then select "Print To File"

Actual Results:
No file is created. Printing is silently failed

Expected Results
pdf or postscript file shpuld be created
Summary: Bug 1156742 - [e10s] Printing with "Print To File" fails → [e10s] Printing with "Print To File" fails
Assignee: nobody → mconley
(In reply to Adrian Florinescu [:AdrianSV] from comment #5)
> Yup, apologies for the mistake. Only after submitting the change I noticed
> the mistake.
> 
> However I can  confirm on Aurora46, print to file behaves as expected.
> (Version 46.0a2 Build ID	20160205004003 User Agent Mozilla/5.0 (X11; Linux
> i686; rv:46.0)

No problem, thanks for testing.

Alice - can you still reproduce this?
Flags: needinfo?(alice0775)
Nightly47.0a1 works as expected.
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
tracking-e10s: + → ---
Flags: needinfo?(alice0775)
Resolution: --- → WORKSFORME
Oops, 
On Ubuntu, It still reproducible on Nightly47.0a1.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
tracking-e10s: --- → ?
Version 47.0a1 Build ID 20160205030204 User Agent Mozilla/5.0 (X11; Linux i686; rv:47.0) Gecko/20100101 
Alice, it works for me on 47 as well, are the STR from the user story complete?
Flags: needinfo?(alice0775)
Forgot to mention, the OS is Ubuntu 14.04.
(In reply to Adrian Florinescu [:AdrianSV] from comment #9)
> Version 47.0a1 Build ID 20160205030204 User Agent Mozilla/5.0 (X11; Linux
> i686; rv:47.0) Gecko/20100101 
> Alice, it works for me on 47 as well, are the STR from the user story
> complete?

On Nightly47.0a1 Ubuntu14.04LTS 32bit

STR
1. "System Tools" > "System Setting" > "Language Support"
    Select "日本語"(Japanese) > click "Apply System-Wide" and close
2. Re-login

3. Start Nightly47.01 with Enabled e10s profile
4. Open Webpage (e.g https://addons.mozilla.org/en-US/firefox/?utm_source=snippet&utm_medium=snippet&utm_campaign=addons )
5. File > Print 
6. Select "Print To File"
7. Make sure, File: ~/desktop/aaaaa.pdf
8. Click "Print"

Actual Results:
No thing is created.

Expected Results:
aaaaa.pdf should be created on desktop.
Disable e10s fixes the problem.

***Strange thing***, if Ubuntu system language is "English" at Step1 fixes the problem.
Flags: needinfo?(alice0775)
Summary: [e10s] Printing with "Print To File" fails → [e10s] Printing with "Print To File" fails, if Ubuntu system language is "Japanese"
Keywords: jp-critical
Thanks Alice for the STR update.
I have reproduced the issue as well on 47Nightly when the system language was set to JP. 
I also did some additional tests and the conclusion i reached is that this behavior is not only JP related, but it reproduces on any language. I got the same malfunction when i set the language to Chinese or Romanian, so my assumption is that no matter what language you set, the print to file will fail.

Also I can confirm that when you set it back to english, print to file works w/o problems.

Note: The build used is the standard Nightly build and not an l10n.
Summary: [e10s] Printing with "Print To File" fails, if Ubuntu system language is "Japanese" → [e10s] Printing with "Print To File" fails, if Ubuntu system language is set to non English language
Assignee: mconley → sotaro.ikeda.g
Ikeda-san, although I have a fix, could you handle this?
Component: Printing: Output → Widget: Gtk
Attachment #8717319 - Flags: review?(karlt) → review+
Comment on attachment 8717319 [details]
MozReview Request: Bug 1184936 - Need convert from UTF8 for printer name. r?karlt

https://reviewboard.mozilla.org/r/34131/#review30829

Thank you!

::: widget/gtk/nsPrintSettingsGTK.cpp:483
(Diff revision 1)
> -  *aPrinter = ToNewUnicode(nsDependentCString(gtkPrintName));
> +  *aPrinter = ToNewUnicode(NS_ConvertUTF8toUTF16(gtkPrintName));

*aPrinter = UTF8ToNewUnicode(nsDependentCString(gtkPrintName));

to save buffer copying and maybe an allocation.
Assignee: sotaro.ikeda.g → m_kato
(In reply to Makoto Kato [:m_kato] from comment #13)
> Ikeda-san, although I have a fix, could you handle this?

Kato-san, thanks a lot for taking the bug!
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/a5f6e1f0e0e8
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Want to uplift this to aurora? It would be nice for printing to work on release for Ubuntu users
Flags: needinfo?(m_kato)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #20)
> Want to uplift this to aurora? It would be nice for printing to work on
> release for Ubuntu users

When Firefox 46 turns on e10s, this is nice that users use non-ASCII printer name on Linux.
Flags: needinfo?(m_kato)
Comment on attachment 8717319 [details]
MozReview Request: Bug 1184936 - Need convert from UTF8 for printer name. r?karlt

Approval Request Comment
[Feature/regressing bug #]:
No

[User impact if declined]:
If printer name has non-ASCII character and users use e10s, Firefox for Linux cannot print web page by it.

[Describe test coverage new/current, TreeHerder]:
Landed in m-c

[Risks and why]:
No.  Because convert string to correct name

[String/UUID change made/needed]:
No
Attachment #8717319 - Flags: approval-mozilla-aurora?
Comment on attachment 8717319 [details]
MozReview Request: Bug 1184936 - Need convert from UTF8 for printer name. r?karlt

Fix for e10s printing regression, ok to uplift to aurora.
Attachment #8717319 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.