Closed Bug 1185005 Opened 5 years ago Closed 5 years ago

Fix panel-header font-size on WebIDE sidebars

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: bstoroz, Assigned: bstoroz)

References

Details

Attachments

(1 file, 1 obsolete file)

A font-size property was messed up for the panel-headers when I went through and fixed up some code style tweaks on 1173089. .panel-header font-size needs to be set to 100%, not 10%.
Attached patch PanelHeaderFontSize.patch (obsolete) — Splinter Review
Updates font-size property.
Attachment #8635362 - Flags: review?(jryans)
Comment on attachment 8635362 [details] [diff] [review]
PanelHeaderFontSize.patch

Review of attachment 8635362 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webide/themes/panel-listing.css
@@ +34,5 @@
>    color: #ACACAC;
>    text-transform: uppercase;
>    line-height: 200%;
>    margin: 5px 5px 0 5px;
> +  font-size: 100%;

It looks like removing the `font-size` rule altogether (allowing it to inherit) has the same effect, so let's do that unless there is a reason not to.
Attachment #8635362 - Flags: review?(jryans) → review+
Property removed
Attachment #8635362 - Attachment is obsolete: true
Attachment #8635619 - Attachment description: NoWifiDevicesDetectedText-v2.patch → PanelHeaderFontSize-v2.patch
Attachment #8635619 - Attachment filename: NoWifiDevicesDetectedText-v2.patch → PanelHeaderFontSize-v2.patch
Attachment #8635619 - Flags: review?(jryans)
Comment on attachment 8635619 [details] [diff] [review]
PanelHeaderFontSize-v2.patch

Review of attachment 8635619 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72e64fe3cb6f
Attachment #8635619 - Flags: review?(jryans) → review+
https://hg.mozilla.org/mozilla-central/rev/fe835839b4ec
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.