Closed
Bug 1185023
Opened 8 years ago
Closed 8 years ago
Add a link to the TreeHerder page corresponding to a push to the hg.m.o template
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ehsan.akhgari, Assigned: gps)
References
Details
Attachments
(1 file)
I think that would be super useful, and it seems like all of the building blocks are there already: the name of the tree and the sha1 of the push are in the "push id" field.
Assignee | ||
Comment 1•8 years ago
|
||
Yes, it would be super useful. I'm kinda surprised there isn't a bug on file, as I know I've thought about this before. This will require some work to map the request's URI back to a TreeHerder tree. I think things are slightly wonky because of the way we have hgweb configured on hg.mozilla.org. Perhaps we should define the TreeHerder "project" name in the hgrc on the server. That feels generically useful and could be used as a quick key to check if the current repository is "indexed" by TreeHerder.
Assignee | ||
Comment 2•8 years ago
|
||
hgmo: link to TreeHerder when possible (bug 1185023); r?smacleod, bkero Linking to Treeherder from the changeset pages is such an obviously useful thing to do. The easiest way to do this is for the repo's hgrc to define which Treeherder repository it is associated with. This is much easier than trying to parse the request's URL into a repository and mapping that to Treeherder. To make the template simpler, I also added a {pushhead} keyword to the pushlog extension.
Attachment #8635527 -
Flags: review?(smacleod)
Attachment #8635527 -
Flags: review?(bkero)
Updated•8 years ago
|
Attachment #8635527 -
Flags: review?(bkero) → review+
Comment 3•8 years ago
|
||
Comment on attachment 8635527 [details] MozReview Request: hgmo: link to TreeHerder when possible (bug 1185023); r?smacleod, bkero https://reviewboard.mozilla.org/r/13559/#review12179 Ship It!
Assignee | ||
Comment 4•8 years ago
|
||
url: https://hg.mozilla.org/hgcustom/version-control-tools/rev/52807622f946c97c437c1d5aa02048d9bc443bfa changeset: 52807622f946c97c437c1d5aa02048d9bc443bfa user: Gregory Szorc <gps@mozilla.com> date: Fri Jul 17 15:15:03 2015 -0700 description: hgmo: link to Treeherder when possible (bug 1185023); r=bkero Linking to Treeherder from the changeset pages is such an obviously useful thing to do. The easiest way to do this is for the repo's hgrc to define which Treeherder repository it is associated with. This is much easier than trying to parse the request's URL into a repository and mapping that to Treeherder. To make the template simpler, I also added a {pushhead} keyword to the pushlog extension.
Assignee | ||
Updated•8 years ago
|
Attachment #8635527 -
Flags: review?(smacleod)
Assignee | ||
Comment 5•8 years ago
|
||
This is deployed. I'm in the process of defining the Treeherder repos in the hgrc files of all relevant repos. But you can already see this in action on e.g. https://hg.mozilla.org/integration/mozilla-inbound/rev/bf79cc1bbe2d.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gps
Reporter | ||
Comment 6•8 years ago
|
||
Thanks for the fast turnaround!
You need to log in
before you can comment on or make changes to this bug.
Description
•