1185176 - "Assertion failure: mStream (How come we don't have a stream here?)" with oscillator

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox)

Debug:

Assertion failure: mStream (How come we don't have a stream here?), at dom/media/webaudio/AudioNode.cpp:297

Release:

Crash [@ mozilla::MediaStream::GraphImpl() ]
bp-2fc31d94-27e8-4e9d-8524-bb5a52150718

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Paul Adenot (:padenot)]

Attachment: Crashtest. r=

A fallout from the optimization where we kill the stream when we know the
it's finished.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Account for the fact that it is possible for nodes to not have streams. r=

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 8637787 [details] [diff] [review]
Account for the fact that it is possible for nodes to not have streams. r=

Thank you.

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8637785 [details] [diff] [review]
Crashtest. r=

Feel free to needinfo me on any bugs I should know about.
I don't find time to read bugmail.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9aecef20996d
https://hg.mozilla.org/integration/mozilla-inbound/rev/472d56e57321

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9aecef20996d
https://hg.mozilla.org/mozilla-central/rev/472d56e57321

Comment 8

[Karl Tomlinson (:karlt)]

Comment on attachment 8637787 [details] [diff] [review]
Account for the fact that it is possible for nodes to not have streams. r=

Approval Request Comment
[Feature/regressing bug #]: bug 974089
[User impact if declined]:
Potential crash.  The is probably not likely in typical Web Audio usage, but some slightly out of ordinary usage could trip this.
[Describe test coverage new/current, TreeHerder]: new crashtest.
[Risks and why]: low risk, simple null check.
[String/UUID change made/needed]: none.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8637787 [details] [diff] [review]
Account for the fact that it is possible for nodes to not have streams. r=

Approved. Crash tests added which is great. Has been in m-c for a few days, seems safe to uplift.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/11446d89a3ad
https://hg.mozilla.org/releases/mozilla-aurora/rev/2215ae5f7406

Comment 11

[Intermittent Failures Robot]

1 failures in 2843 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1185176&startday=2019-04-01&endday=2019-04-07&tree=all