1185224 - add --restore option to command line interface

Status: RESOLVED WORKSFORME

(Firefox :: Untriaged, defect)

Description

[u123541]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20150717030202

Steps to reproduce:

Setting up cron to restart my Nightly after daily download.


Actual results:

Nightly starts with "Restore previous session" requiring click and wait time while it restores S..L..O..W..L..Y (I have MANY windows and tabs open).  Because of this delay in starting, I often only restart Nightly weekly.


Expected results:

Please add --restore option to restart Nightly in same state it was in when I went to sleep.  My goal is to restart Nightly while I sleep -- not have to wait several minutes for it to restore my session.

Comment 1

[Nickolay_Ponomarev]

>Nightly starts with "Restore previous session"
Do you mean the "Well, this is embarrassing" (about:sessionrestore) page?

It's only supposed to show up if Firefox doesn't shut down correctly, so I don't think code to allow force-skipping it will be added.

I believe we use http://mxr.mozilla.org/mozilla-central/source/toolkit/components/crashmonitor/CrashMonitor.jsm and sessionCheckpoints.json in the profile to detect when to show the about:sessionrestore page <http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/nsSessionStartup.js#7>

If you find the specific instances where the crash-detection doesn't work as it should, it could be a valid bug worth fixing.

Comment 2

[u123541]

These are the ONLY ways Nightly gets shutdown/restarted here...
1. File->Quit -- this always results in a "restore session" page. Rarely does "embarrassing" occur.
2. Crash, report dialog, restart -- rare, so IIRC, those restarts bypass "restore session"
3. tab crash (once lately, every tab on every window) -- used step 1 since restore tabs failed.

Comment 3

[Nickolay_Ponomarev]

>1. File->Quit -- this always results in a "restore session" page. Rarely does "embarrassing" occur.

I don't understand this. I thought we had a single sessionrestore page, with a large "Well, this is embarrassing" text. You seem to state there's another page that offers the "restore session" button, but does not have the "embarrassing" title. Can you attach its screenshot? Are you sure it's not coming from an extension?

Comment 4

[u123541]

Attachment: 1185224.jpg

From another userid I test basic Nightly with when necessary...
This doesn't look familiar to you?  :)
No addons. Only the default codec plugin.

Comment 5

[Nickolay_Ponomarev]

Ah, that's called the default 'Nightly Start Page' (about:home). Why don't you set 'Options -> General -> When Nightly starts - Show my windows and tabs from last time'?

Comment 6

[u123541]

Various reasons:
0. searched everywhere but in that dropdown
1. used "blank page" for years. Hated "current" & "<specific page>".  "last time" is new to me...
2. searched about:config for "restore": nothing there.
3. can't remember last time I read release notes...  should be more obvious**

** probably would be WONTFIX; but wishful thinking --> it would be great to raise "New Preference[s] [option[s]]" changes all the way up to the Edit menu (via colored text or somesuch) until the user has at least seen whatever is new.

Thanks! That should take care of the restart from cron...  --restore would be nice as an optional way to restart from the command line; but this works.  :)