Closed Bug 1185241 Opened 9 years ago Closed 9 years ago

Logging out when or after impersonating a user doesn't delete cookies from the logincookies table correctly

Categories

(Bugzilla :: User Accounts, defect)

Product:
Bugzilla
Component:
User Accounts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 6.0

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file, 1 obsolete file)

patch, v1.1
6.75 KB, patch
dkl
: review+
Details | Diff | Splinter Review 
When impersonating a user, a new logincookie is created in the DB, using the sudoer ID. If you click "log out" while impersonating a user, no logincookie is removed from the DB. If you first click "end session" and then "log out", only the logincookie created when starting the sudo session is removed. The original logincookie is still stored in the DB.
Summary: Logging out when or after impersonating a user doesn't delete cookies from the logincookies correctly → Logging out when or after impersonating a user doesn't delete cookies from the logincookies table correctly
I have a fix for this bug, but to avoid duplicating code, I need the new check_current_password() method that sgreen is implementing in bug 670669.
Assignee: user-accounts → LpSolit
Status: NEW → ASSIGNED
Depends on: 670669
Attached patch patch, v1 (obsolete) — — Splinter Review 
Not requesting review yet, because some code in relogin.cgi can be replaced by check_current_password() once this method is available, see my previous comment.

/me likes when fixing a bug means removing a lot of useless code. :)
Attached patch patch, v1.1 — — Splinter Review 

        Attachment #8635785 -
        Attachment is obsolete: true

        Attachment #8651513 -
        Flags: review?(dkl)

    
  
Target Milestone: --- → Bugzilla 6.0

    
    

    
  
Comment on attachment 8651513 [details] [diff] [review]
patch, v1.1

Review of attachment 8651513 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

        Attachment #8651513 -
        Flags: review?(dkl) → review+
Flags: approval?

    
    

    
  
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   a72defc..3db657e  master -> master
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: approval?
Resolution: --- → FIXED
Blocks: 1225564

    
  
Blocks: 392311

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: