Closed Bug 1185263 Opened 7 years ago Closed 3 years ago

Remove manual package manifest preprocessing

Categories

(Instantbird :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: philip.chee, Unassigned)

References

(Blocks 1 open bug)

Details

+++ This bug was initially created as a clone of Bug #1184446 +++

(From Bug 1184446 comment #1)
> Created attachment 8634585 [details] [diff] [review] [diff] [review]
> Remove manual package manifest preprocessing
> 
> packager.py itself has been able to do preprocessing since the beginning.
> For some reason, Makefile.in-driven preprocessing was kept back then, and
> never was removed, and even worse, concatenation was added on top of it.
> 
> There is however a downside to the current way of doing things: error
> reporting is given relative to the given manifest, which in the current
> case is the preprocessed/concatenated file, so line numbers don't match
> what is in the file in the source tree. However, when packager.py does
> preprocessing itself, line numbers are reported properly.
> 
> Thus, switch all package manifests to packager.py-driven preprocessing.
> 
> I validated that this doesn't change the list of files in the resulting
> firefox builds on try.
On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.