1185269 - [Settings] Convert radio controls to use gaia-radio

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Kevin Grandon :kgrandon]

In preparation for moving to web components.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1185269_settings_radio_component > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8635735 [details] [review]
[gaia] KevinGrandon:bug_1185269_settings_radio_component > mozilla-b2g:master

Hey Fred - would you have time to review this one? This finished porting radio controls over to use web components, and after this just switches remain before we can remove switches.css. Thanks!

Comment 3

[[e-mail]]

Comment on attachment 8635735 [details] [review]
[gaia] KevinGrandon:bug_1185269_settings_radio_component > mozilla-b2g:master

The other looks good but be careful with panel_utils, which might break other elements behavior.

Please run `make raptor` then run `APP=settings node tests/raptor/launch_test RUNS=30` on flame, paste before/after patch result on this bug to check that we did not bring the loadtime regression with this patch.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8635735 [details] [review]
[gaia] KevinGrandon:bug_1185269_settings_radio_component > mozilla-b2g:master

Hi Fred,

Thanks for taking a look. This time it's a little bit more conservative with the panel utils changes. We no longer use any plain radio elements, so ripped that out for gaia-radio. Once we convert all of the pack-switch elements to gaia-switch we should be able to remove that usage from panel utils as well. Thanks!

Comment 5

[[e-mail]]

Got error when accessing WPS panel

E/Settings( 4325): [JavaScript Error: "TypeError: this._wrapper is undefined" {file: "app://settings.gaiamobile.org/shared/elements/gaia_radio/script.js" line: 127}]

Comment 6

[[e-mail]]

Attachment: radio_overlap.png

The message is overlap the radio button in Cellular & Data > SIM Settings > APN Settings > data settings/A-GPS Settings

Comment 7

[[e-mail]]

Comment on attachment 8635735 [details] [review]
[gaia] KevinGrandon:bug_1185269_settings_radio_component > mozilla-b2g:master

Thanks for this good work, we are pretty close now. Please address above issues and flag review again.

(The raptor is now enabled in treeherder, no need provide loadtime data manually \o/)

Comment 8

[Kevin Grandon :kgrandon]

Thanks for the quick reviews! Will address the issues and mark you for review soon.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8635735 [details] [review]
[gaia] KevinGrandon:bug_1185269_settings_radio_component > mozilla-b2g:master

Hi Fred,

Please take a look if you have a chance. I've addressed some review concerns, and for the ease of reviewing some of the fixes live in different commits. I will squash these before merging. Thanks!

Comment 10

[[e-mail]]

Comment on attachment 8635735 [details] [review]
[gaia] KevinGrandon:bug_1185269_settings_radio_component > mozilla-b2g:master

test on device and all looks good now

Comment 11

[Kevin Grandon :kgrandon]

Thank you for the review cycles!

In master, please let me know if you spot any regressions: https://github.com/mozilla-b2g/gaia/commit/9a45076c37ad2139f25194613916af5efb55bbc7