Closed
Bug 1185406
Opened 10 years ago
Closed 10 years ago
B2G RIL: Read 'pcscf' from data call response since RIL version 10
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(tracking-b2g:backlog, firefox43 fixed)
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: jessica, Assigned: jessica)
Details
Attachments
(1 file, 2 obsolete files)
|
11.63 KB,
patch
|
jessica
:
review+
|
Details | Diff | Splinter Review |
'pcscf' in data call response was introduced in RIL version 10 [1]. 'pcscf' is the Proxy Call State Control Function address via PCO(Protocol Configuration Option) for IMS client.
[1] https://android.googlesource.com/platform/hardware/ril/+/d365219a1873e42d2ff669e13a9fe6ce6973bd51%5E!/include/telephony/ril.h
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → jjong
|
|
Assignee | |
Comment 3•10 years ago
|
||
For tests, only emulator-l support RIL version >= 10 at the moment, and we need to consider how to report pcscf from emulator modem, since pcscf is only available when ims pdp is setup. Since emulator modem does not know the type of apn it is handling when setuping pdp, maybe we can predefine a special apn for ims, so that emulator modem knows when to report pcscf. Any other ideas are welcome.
|
|
Assignee | |
Comment 4•10 years ago
|
||
rebased after bug 1167132.
Attachment #8635931 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8644228 [details] [diff] [review]
patch, v2.
Hsinyi, do you think we can review/land this patch first, and handle test cases in a separate bug, once emulator-l is ready? Thanks.
Attachment #8644228 -
Flags: review?(htsai)
|
||
Updated•10 years ago
|
Attachment #8644228 -
Flags: review?(htsai) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8644228 -
Attachment is obsolete: true
Attachment #8648662 -
Flags: review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
Thanks Hsinyi.
try looks good except for some known failures:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=40ec36e2a837
|
|
Assignee | |
Comment 8•10 years ago
|
||
(In reply to Jessica Jong [:jjong] [:jessica] from comment #5)
> Comment on attachment 8644228 [details] [diff] [review]
> patch, v2.
>
> Hsinyi, do you think we can review/land this patch first, and handle test
> cases in a separate bug, once emulator-l is ready? Thanks.
Filed bug 1195595 for emulator and tests part.
|
||
Comment 10•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S5 (21Aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•