Closed Bug 1185453 Opened 4 years ago Closed 4 years ago

Enable error summary file generation.

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
Tracking Status
firefox42 --- fixed

People

(Reporter: jgraham, Assigned: jgraham)

References

Details

Attachments

(1 file)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=888dcd198f30 - notice the [suite]_errorsummary.log files.
Bug 1185453 - Generate error summary files for failures, r?chmanchester
Attachment #8635932 - Flags: review?(cmanchester)
Blocks: 1177630
Comment on attachment 8635932 [details]
MozReview Request: Bug 1185453 - Generate error summary files for failures, r?chmanchester

https://reviewboard.mozilla.org/r/13605/#review12251

::: testing/config/mozharness/android_arm_4_3_config.py:91
(Diff revision 1)
> +                "--app=%(app)s",
> +                "--ignore-window-size",
>                  "--dm_trans=adb",
>                  "--bootstrap",
> -                "--remote-webserver=%(remote_webserver)s", "--xre-path=%(xre_path)s",
> +                "--remote-webserver=%(remote_webserver)s",

All this random reformatting makes this patch a pain to review.

::: testing/config/mozharness/android_arm_config.py:97
(Diff revision 1)
> -            "options": [ "--app=%(app)s", "--ignore-window-size",
> +            "options": [ "--app=%(app)s",

This started getting inconsistent, the first item is on a new line in other entries.

::: testing/mozharness/mozharness.json:1
(Diff revision 1)
>  {
> -    "repo": "https://hg.mozilla.org/build/mozharness",
> -    "revision": "239491bc393a"
> +    "repo": "https://hg.mozilla.org/users/james_hoppipolla.co.uk/mozharness",
> +    "revision": "04c69b07c826"
>  }

This is defunct.

::: testing/mozharness/scripts/androidx86_emulator_unittest.py:423
(Diff revision 1)
> +                                              '%s_errorsummary.log' % suite_name)

Weird indentation.

::: testing/mozharness/scripts/web_platform_tests.py:127
(Diff revision 1)
> -                     "--stackwalk-binary=%s" % self.query_minidump_stackwalk()]
> +                     "--stackwalk-binary=%s" % "/home/jgraham/Downloads/minidump_stackwalk"]

Obviously don't check this in.
Attachment #8635932 - Flags: review?(cmanchester) → review+
https://reviewboard.mozilla.org/r/13605/#review12251

> All this random reformatting makes this patch a pain to review.

Yeah, it should have been two commits, but it was hard to split out. Sorry.
Comment on attachment 8635932 [details]
MozReview Request: Bug 1185453 - Generate error summary files for failures, r?chmanchester

Bug 1185453 - Generate error summary files for failures, r?chmanchester
Attachment #8635932 - Flags: review+ → review?(cmanchester)
Attachment #8635932 - Flags: review?(cmanchester) → review+
Comment on attachment 8635932 [details]
MozReview Request: Bug 1185453 - Generate error summary files for failures, r?chmanchester

https://reviewboard.mozilla.org/r/13605/#review12337

Ship It!
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/df2c4d64382042e7a5f16c28835552239d29e65d
changeset:  df2c4d64382042e7a5f16c28835552239d29e65d
user:       James Graham <james@hoppipolla.co.uk>
date:       Mon Jul 20 10:39:03 2015 +0100
description:
Bug 1185453 - Generate error summary files for failures, r=chmanchester
sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=11997787&repo=mozilla-inbound
Flags: needinfo?(james)
url:        https://hg.mozilla.org/build/mozharness/rev/8978f498da2b542967df7fb5957cf1cc29769b70
changeset:  8978f498da2b542967df7fb5957cf1cc29769b70
user:       James Graham <james@hoppipolla.co.uk>
date:       Fri Jul 24 17:45:50 2015 +0100
description:
Bug 1185453 - Generate error summary files for failures, r=chmanchester
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/fcaafcb5f0eee5428d104a5e8d0c21043da6041a
changeset:  fcaafcb5f0eee5428d104a5e8d0c21043da6041a
user:       James Graham <james@hoppipolla.co.uk>
date:       Mon Jul 20 10:39:03 2015 +0100
description:
Bug 1185453 - Generate error summary files for failures, r=chmanchester
Flags: needinfo?(james)
https://hg.mozilla.org/mozilla-central/rev/fcaafcb5f0ee
Assignee: nobody → james
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Ah, I forgot to answer this in the bug. This is working as intended; unfortunately the error summaries for successful jobs are currently zero-length files that nevertheless get uploaded. It would be nice to fix this in the future, but it's a polish issue rather than fundamental brokenness.
Flags: needinfo?(james)
Depends on: 1191375
You need to log in before you can comment on or make changes to this bug.