1185453 - Enable error summary file generation.

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[James Graham [:jgraham]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=888dcd198f30 - notice the [suite]_errorsummary.log files.

Comment 1

[James Graham [:jgraham]]

Attachment: MozReview Request: Bug 1185453 - Generate error summary files for failures, r?chmanchester

Bug 1185453 - Generate error summary files for failures, r?chmanchester

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8635932 [details]
MozReview Request: Bug 1185453 - Generate error summary files for failures, r?chmanchester

https://reviewboard.mozilla.org/r/13605/#review12251

::: testing/config/mozharness/android_arm_4_3_config.py:91
(Diff revision 1)
> +                "--app=%(app)s",
> +                "--ignore-window-size",
>                  "--dm_trans=adb",
>                  "--bootstrap",
> -                "--remote-webserver=%(remote_webserver)s", "--xre-path=%(xre_path)s",
> +                "--remote-webserver=%(remote_webserver)s",

All this random reformatting makes this patch a pain to review.

::: testing/config/mozharness/android_arm_config.py:97
(Diff revision 1)
> -            "options": [ "--app=%(app)s", "--ignore-window-size",
> +            "options": [ "--app=%(app)s",

This started getting inconsistent, the first item is on a new line in other entries.

::: testing/mozharness/mozharness.json:1
(Diff revision 1)
>  {
> -    "repo": "https://hg.mozilla.org/build/mozharness",
> -    "revision": "239491bc393a"
> +    "repo": "https://hg.mozilla.org/users/james_hoppipolla.co.uk/mozharness",
> +    "revision": "04c69b07c826"
>  }

This is defunct.

::: testing/mozharness/scripts/androidx86_emulator_unittest.py:423
(Diff revision 1)
> +                                              '%s_errorsummary.log' % suite_name)

Weird indentation.

::: testing/mozharness/scripts/web_platform_tests.py:127
(Diff revision 1)
> -                     "--stackwalk-binary=%s" % self.query_minidump_stackwalk()]
> +                     "--stackwalk-binary=%s" % "/home/jgraham/Downloads/minidump_stackwalk"]

Obviously don't check this in.

Comment 3

[James Graham [:jgraham]]

https://reviewboard.mozilla.org/r/13605/#review12251

> All this random reformatting makes this patch a pain to review.

Yeah, it should have been two commits, but it was hard to split out. Sorry.

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8635932 [details]
MozReview Request: Bug 1185453 - Generate error summary files for failures, r?chmanchester

Bug 1185453 - Generate error summary files for failures, r?chmanchester

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8635932 [details]
MozReview Request: Bug 1185453 - Generate error summary files for failures, r?chmanchester

https://reviewboard.mozilla.org/r/13605/#review12337

Ship It!

Comment 6

[James Graham [:jgraham]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/df2c4d64382042e7a5f16c28835552239d29e65d
changeset:  df2c4d64382042e7a5f16c28835552239d29e65d
user:       James Graham <[e-mail]>
date:       Mon Jul 20 10:39:03 2015 +0100
description:
Bug 1185453 - Generate error summary files for failures, r=chmanchester

Comment 7

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=11997787&repo=mozilla-inbound

Comment 8

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bb16e78324d

Comment 9

[James Graham [:jgraham]]

url:        https://hg.mozilla.org/build/mozharness/rev/8978f498da2b542967df7fb5957cf1cc29769b70
changeset:  8978f498da2b542967df7fb5957cf1cc29769b70
user:       James Graham <[e-mail]>
date:       Fri Jul 24 17:45:50 2015 +0100
description:
Bug 1185453 - Generate error summary files for failures, r=chmanchester

Comment 10

[James Graham [:jgraham]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=190e22692439

Comment 11

[Chris Cooper [:coop] (he/him)]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/2da0b7595468

Comment 12

[James Graham [:jgraham]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/fcaafcb5f0eee5428d104a5e8d0c21043da6041a
changeset:  fcaafcb5f0eee5428d104a5e8d0c21043da6041a
user:       James Graham <[e-mail]>
date:       Mon Jul 20 10:39:03 2015 +0100
description:
Bug 1185453 - Generate error summary files for failures, r=chmanchester

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fcaafcb5f0ee

Comment 14

[Ed Morley [:emorley]]

I tried looking at the try run in comment 0:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=888dcd198f30

But all the error summary links I found via the "job details" tab in Treeherder, eg:
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/c9ad803031fa1c0238ee4d02fcf5e23ced8aa2623ff781abca130d3388bb369ad44477520bfe6b77390e1a99fb6d8c7828ce08e40340199ea08ffcc8140a37b5
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/7bc711911a92a8c1052c1c23bcb62fd865330f26bd51c594570dd7c410ea235bb1559f0fc3dfc5b861f2d05630d06ed9893ed62b48639b3502ad70858e9f3b67
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/1f3bb45e71fc3ed050325fa8a285ac8722db380691a376aa6a7e7372b3de8a0fe31fc8f08ab7c2470e1a4699681cc0e184670a89191f0568a8f477881c1dbc19

Return no content.

Is there something up with the error summaries, S3 or the links Treeherder generates (which is the same method as the other blobber_files URLs)?

Comment 15

[James Graham [:jgraham]]

Ah, I forgot to answer this in the bug. This is working as intended; unfortunately the error summaries for successful jobs are currently zero-length files that nevertheless get uploaded. It would be nice to fix this in the future, but it's a polish issue rather than fundamental brokenness.