1185562 - Make it clear that running 'mach mercurial-setup' unblocks 'mach build' even if it results in an error

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Botond Ballo [:botond]]

I just pulled m-c and did 'mach build', and got a message saying that I need to run 'mach mercurial-setup' before proceeding (this was added in bug 1182677).

I then ran 'mach mercurial-setup', which resulted in an error (I filed bug 1185561 for the error).

At this point, I thought I was stuck and couldn't build, as 'mach build' told me it required 'mach mercurial-setup' but 'mach mercurial-setup' gave an error.

In fact, the running of 'mach mercurial-setup' unblocks 'mach build' even if it results in an error. This should be made clear to users, so they don't think they are stuck if mercurial-setup gives an error.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1185562 - Print message saying the mercurial-setup failures unblock mach; r?smacleod

Bug 1185562 - Print message saying the mercurial-setup failures unblock mach; r?smacleod

The messaging on this could be bikeshedded. Something is better than
nothing, that's for sure.

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8636173 [details]
MozReview Request: Bug 1185562 - Print message saying the mercurial-setup failures unblock mach; r?smacleod

https://reviewboard.mozilla.org/r/13653/#review12319

Ship It!

Comment 3

[Gregory Szorc [:gps]]

url:        https://hg.mozilla.org/integration/fx-team/rev/e8b16203fdb2fed525f03792d3e8f50146f3d909
changeset:  e8b16203fdb2fed525f03792d3e8f50146f3d909
user:       Gregory Szorc <[e-mail]>
date:       Tue Jul 21 10:09:49 2015 -0700
description:
Bug 1185562 - Print message saying the mercurial-setup failures unblock mach; r=smacleod

The messaging on this could be bikeshedded. Something is better than
nothing, that's for sure.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e8b16203fdb2