1185632 - [mozinfo] mozinfo.os is 'unknown' running under MSYS2 on Windows 8.1 x64

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Ed Morley [:emorley]]

(mozregression)[~/src/tmp]$ python -c 'import mozinfo; print mozinfo.os'
UNKNOWN

(mozregression)[~/src/tmp]$ python -c 'import platform; print platform.uname()[0]'
MINGW32_NT-6.3

This is causing bug 1185602 (I'll leave that bug in the mozregression component, since it can be used to handle the "unknown" OS more gracefully).

Comment 1

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/file/b894570f9083/testing/mozbase/mozinfo/mozinfo/mozinfo.py#l40
    40 if system in ["Microsoft", "Windows"]:

Comment 2

[Ed Morley [:emorley]]

I should add I'm using the msys2 python package, rather than the win32 standalone python install.

Even if I make adjust the line referenced in comment 1, so that we follow that codepath, I then get:

(mozregression)[~/src/tmp]$ mozregression --good 2015-01-02
Traceback (most recent call last):
  File "/home/Ed/.virtualenvs/mozregression/bin/mozregression", line 7, in <module>
    from mozregression.main import cli
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozregression/main.py", line 11, in <module>
    import mozinfo
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozinfo/__init__.py", line 54, in <module>
    import mozinfo
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozinfo/mozinfo.py", line 47, in <module>
    (major, minor, _, _, service_pack) = os.sys.getwindowsversion()
AttributeError: 'module' object has no attribute 'getwindowsversion'

Comment 3

[Ed Morley [:emorley]]

Editing mozinfo to temporarily hardcode the version/service pack (to work around the exception in comment 2), then gives:

(mozregression)[~/src/tmp]$ mozregression --good 2015-01-02
Traceback (most recent call last):
  File "/home/Ed/.virtualenvs/mozregression/bin/mozregression", line 7, in <module>
    from mozregression.main import cli
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozregression/main.py", line 32, in <module>
    from mozregression.launchers import REGISTRY as APP_REGISTRY
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozregression/launchers.py", line 14, in <module>
    from mozrunner import Runner
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozrunner/__init__.py", line 4, in <module>
    from .cli import *
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozrunner/cli.py", line 11, in <module>
    from .runners import runners
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozrunner/runners.py", line 11, in <module>
    from .base import DeviceRunner, GeckoRuntimeRunner
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozrunner/base/__init__.py", line 1, in <module>

    from .runner import BaseRunner
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozrunner/base/runner.py", line 13, in <module>
    import mozcrash
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozcrash/__init__.py", line 8, in <module>
    from mozcrash import *
  File "/home/Ed/.virtualenvs/mozregression/lib/python2.7/site-packages/mozcrash/mozcrash.py", line 348, in <module>
    kernel32 = ctypes.windll.kernel32
AttributeError: 'module' object has no attribute 'windll'

:-(
(Even though we don't need to use mozcrash)

Comment 4

[(not currently active) Ted Mielczarek]

Sounds like we don't support MSYS Python very well. We can either state that up front--that we only support native Windows Python, or we can fix things to work under MSYS Python as best as possible. That might mean that some bits of things like mozcrash won't work, but I also wouldn't be surprised to find that various other things don't work, since I'm pretty sure we're only testing with Windows Python.

Comment 5

[Julien Pagès (:parkouss)]

Ok, so let's fix only the mozinfo.os member for now, so mozregression (and possibly other tools like mozdownload) can work as expected on MSYS.

Comment 6

[Julien Pagès (:parkouss)]

Attachment: MozReview Request: Bug 1185632 - [mozinfo] mozinfo.os is unknown running under MSYS. r=wlach

Bug 1185632 - [mozinfo] mozinfo.os is unknown running under MSYS. r=wlach

Comment 7

[Julien Pagès (:parkouss)]

Attachment: MozReview Request: Bug 1185632 - [mozinfo] bump release to 0.9. r=wlach

Bug 1185632 - [mozinfo] bump release to 0.9. r=wlach

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8681372 [details]
MozReview Request: Bug 1185632 - [mozinfo] bump release to 0.9. r=wlach

https://reviewboard.mozilla.org/r/23817/#review21281

Comment 9

[William Lachance (:wlach)]

Comment on attachment 8681371 [details]
MozReview Request: Bug 1185632 - [mozinfo] mozinfo.os is unknown running under MSYS. r=wlach

https://reviewboard.mozilla.org/r/23815/#review21283

Comment 10

[Julien Pagès (:parkouss)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d83ded439ad9a36c26005deeab2c49527a0ef438
Bug 1185632 - [mozinfo] mozinfo.os is unknown running under MSYS. r=wlach

https://hg.mozilla.org/integration/mozilla-inbound/rev/b06b718839f9abd3aa81c2f734380c9523bdbd1f
Bug 1185632 - [mozinfo] bump release to 0.9. r=wlach

Comment 11

[Julien Pagès (:parkouss)]

I will release it on pypi once patches are in m-c.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d83ded439ad9
https://hg.mozilla.org/mozilla-central/rev/b06b718839f9

Comment 13

[Julien Pagès (:parkouss)]

Done:

Submitting dist/mozinfo-0.9.tar.gz to https://pypi.python.org/pypi
Server response (200): OK

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d83ded439ad9
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b06b718839f9

Comment 15

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 16

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.