Closed
Bug 1185678
Opened 10 years ago
Closed 10 years ago
Create Parse Context object for L20n Parsers
Categories
(Firefox OS Graveyard :: Gaia::L10n, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
Details
Attachments
(1 file)
We're currently storing parsing internal state on the Parser object. We should instead store it on the temporary object that extends the Parser object.
|
Assignee | |
Comment 1•10 years ago
|
||
How does it look to you?
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8636211 [details] [review]
pull request
per PR, f=me
Attachment #8636211 -
Flags: feedback?(l10n) → feedback+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8636211 [details] [review]
pull request
Stas, can you review this?
Attachment #8636211 -
Flags: review?(stas)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8636211 -
Flags: review?(l10n)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8636211 [details] [review]
pull request
r=me with a comment left in github about tool/parse and the entries parser.
Attachment #8636211 -
Flags: review?(stas) → review+
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8636211 [details] [review]
pull request
I think I've looked at this to the extent that I understand the code, so did stas. Our last comments were addressed, r=me.
Attachment #8636211 -
Flags: review?(l10n) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•