The update-status badge on #PanelUI-menu-button isn't visible anymore

RESOLVED FIXED in Firefox 42

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bgrins, Assigned: neil@parkwaycc.co.uk)

Tracking

({regression})

Trunk
Firefox 42
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
After Bug 1029937, the markup for toolbarbutton-badges changed.  But there is still one instance of toolbarbutton-badge::after referenced in browser/themes/shared/customizableui/panelUIOverlay.inc.css: http://mxr.mozilla.org/mozilla-central/search?string=toolbarbutton-badge%3A%3Aafter.

This means that the green arrow shown when there is a pending update isn't visible.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1029937#c44.
(Reporter)

Comment 1

3 years ago
Created attachment 8636239 [details]
badge-osx.png

Moving the discussion from Bug 1029937 to here.  As per my review comment, there is an issue on osx with an unfocused window.

Here's a screenshot with the patch from Bug 1029937 applied in OSX showing an issue with the icon being clipped when the window is unfocused.  Looks like there is a 1px border applied to .toolbarbutton-badge:-moz-window-inactive from toolbarbuttons.css which causes the issue.  It might be simplest to just apply border: none to the #PanelUI-menu-button[update-status="succeeded"] > .toolbarbutton-badge-stack > .toolbarbutton-badge rule.
Flags: needinfo?(neil)
(Assignee)

Comment 2

3 years ago
(In reply to Brian Grinstead from comment #1)
> Looks like there is a 1px border applied to .toolbarbutton-badge:-moz-window-inactive

(Yeah, I did wonder about that at the time when writing the patch for bug 1029937, it seems odd to change the size of UI depending on whether the window is active or not.)
Flags: needinfo?(neil)
(Assignee)

Comment 3

3 years ago
Created attachment 8636573 [details] [diff] [review]
Revised patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8636573 - Flags: review?(bgrinstead)
(Reporter)

Updated

3 years ago
Attachment #8636573 - Flags: review?(bgrinstead) → review+

Updated

3 years ago
Blocks: 1180584
https://hg.mozilla.org/mozilla-central/rev/f74712e20ab2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.