1185752 - Use TraceableHashMap to simplify CloneMemory

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: replace_CloneMemory_with_rooted-v0.diff

The first patch is basically just adding a new typedef. The second patch removes the orphaned AutoObjectUnsignedHashMap.

Comment 1

[Terrence Cole [:terrence]]

Attachment: remove_AutoObjectUnsigned32HashMap-v0.diff

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8636270 [details] [diff] [review]
replace_CloneMemory_with_rooted-v0.diff

Review of attachment 8636270 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/StructuredClone.cpp
@@ +267,5 @@
>                                       void* cbClosure,
>                                       Value tVal)
>          : out(cx), objs(out.context()),
>            counts(out.context()), entries(out.context()),
> +          memory(out.context(), mozilla::Move(CloneMemory(out.context()))), callbacks(cb),

Admittedly, I'm pretty shaky on this stuff, but isn't that mozilla::Move redundant here?

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8636271 [details] [diff] [review]
remove_AutoObjectUnsigned32HashMap-v0.diff

Review of attachment 8636271 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 4

[Terrence Cole [:terrence]]

(In reply to Steve Fink [:sfink, :s:] from comment #2)
> 
> Admittedly, I'm pretty shaky on this stuff, but isn't that mozilla::Move
> redundant here?

For some reason both clang and gcc were insisting on selecting the deleted copy constructor without it. It doesn't reproduce when I retried now though, so I guess I there was something else wrong that I've fixed in the meantime.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b01ff214a2d
https://hg.mozilla.org/integration/mozilla-inbound/rev/09dfd750825a

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7b01ff214a2d
https://hg.mozilla.org/mozilla-central/rev/09dfd750825a