1185770 - Promises actor does not need global: true

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 1084525, a promises actor was added, but was set as:

      type: { global: true, tab: true }

in server/main.js[1].

global: true is only meant for actors that correspond to the entire application, like "preferences".  Actors that are meant to used in a page context, including browser toolbox, etc. only need tab: true.

We should remove global: true, unless there is something I'm missing here.

[1]: https://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/main.js#551

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:gl, can you take a look at this?

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1185770.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=27f58c1e10e6

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/27068096ac99

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/27068096ac99