Closed Bug 1185814 Opened 5 years ago Closed 5 years ago

Disable ClearKey EME test on 10.6

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The current EME clearkey tests intermittently timeout in 10.6.

The current code path will never be used on 10.6 other than in those tests and ultimately, it will use a GMP ClearKey plugin rather than what is currently there.

Decision was made to completely disable those tests on 10.6 instead.
Attachment #8636406 - Flags: review?(cpearce)
Comment on attachment 8636406 [details] [diff] [review]
Disable EME tests on 10.6.

Review of attachment 8636406 [details] [diff] [review]:
-----------------------------------------------------------------

You should have a todo("Test disabled on this platform"); in each of these.

I think you are better to avoid calling into the MediaTestManager at all. You should basically do:

if (!MacOSX106()) {
  SimpleleTest.waitForExplicitFinish();
  SetupEMEPref(beginTest);  
} else {
  todo("Test disabled on this platform");
}
Attachment #8636406 - Flags: review?(cpearce) → review-
Attachment #8636900 - Flags: review?(cpearce)
Comment on attachment 8636900 [details] [diff] [review]
Disable EME tests on 10.6.

Review of attachment 8636900 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8636900 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/59b1af051414
Assignee: nobody → jyavenard
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.