118585 - Properties in nsAbLDAPProperties.cpp

Status: RESOLVED DUPLICATE of bug 157925

(MailNews Core :: LDAP Integration, defect)

Description

[Kristof Petr]

Table for mapping addressbook properties and LDAP properties
is very uncomplete.

I did spent time to found OIDs for current LDAP attributes, add comments,
add more new attributes. I did make abzillaperson ldap schema for all
mozilla specific attributes for easy building ldap based adressbook.

There are three files:

1) Table what show relation between addressbook and ldap
ftp://crash.fce.vutbr.cz/ldap/abzilla/oid.txt

2) Abzillaperson schema
ftp://crash.fce.vutbr.cz/ldap/abzilla/abzillaperson.schema

3) Patch to add more attributes
ftp://crash.fce.vutbr.cz/ldap/abzilla/nsAbLDAPProperties.patch

NOTE: This patch doesnt change any behavior or function
of Mozilla. It updates properties only and make it more
complete.

All comments and suggestion are welcome.

PS. DanM, can you push it to sources before 0.9.8 freeze, please?

Thanks
  Petr

Comment 1

[Kristof Petr]

Attachment: Mapping overview table

Comment 2

[Kristof Petr]

Attachment: abzillaperson schema

Comment 3

[Kristof Petr]

Attachment: More properties patch

Comment 4

[Mark Smith [:mcs]]

Reassigned to Dan because he probably knows who this bug should be assigned to.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Giving to John Marmion, as this is largely Sun Ireland code.

Comment 6

[John Marmion]

See also my comments on bug #118454.

Firstly, I am not keen to get involved in agreeing schemas. I will make a
contribution on the nsAbLDAPProperties.cpp. As I have said previously, ideally
the mapping should be user-defined but in the meantime we have the hard-coded
Mozilla Address Book mapping to LDAP attributes to deal with. I am keen to do
the 'right thing' here.

Looking at the patch for the nsAbLDAPProperties.cpp, I don't agree that this
patch does "not change behaviour or function of Mozilla". Adding new attributes,
changing the order will effect the behaviour of the existing code. I can count
the following changes in behaviour and functionality:

1. Changing the order of 'fax' and 'facsimilenumber' appearing in the table will
have the following effects. If both exist then the first one to appear will get
mapped to 'FaxNumber' in the Address Book as we are using a Hashtable. Also in
the advanced search of bug #83023 then the order they appear in will determine
the query string that is created if FaxNumber is in the query. I must log a bug
against this!

2. Changing the case of e.g. givenName from givenname.

3. Changing 'street' to 'streetaddress' and changed order with 'postOfficeBox'.

4. Added 'homeStreet', 'homeLocalityName', 'homeState', 'homePostalCode',
'homeCountryName'.

5. Added 'c' for WorkCountry and put before 'countryName'.

6. Reversed order of 'notes' and 'description' 

7. delete second use of 'WorkCountry'.

But the real point is are these changes for the better. They certainaly appear
to be. I am keen that we support and resuse existing LDAP attributes. The issue
of in what order they appear is important and are we using the most commonly
used ones. We need to agree some rules of thumb. One possible suhc order is use
e.g.

WorkCountry	'c'
WorkCountry	'countryName'

i.e. abbreviations first

but what about 'streetAddress' and 'postOfficeBox' or 'fax' and
'facsimilenumber'

Should we also be supporting 'co' for WorkCountry?

Comment 7

[Kristof Petr]

OK. You have more deep mozilla source knowledge over me.
Its the first time Im trying to define ldap schema and it is far away from ideal.

I did maximal effort to use existing ldap attributes and new created homexxx has
equivalent
SYNTAX () to corresponding existing workxxx attributes.

The first question is: What prefix we should use for new defined
attributes? home(xxx) or mozilla(xxx) or each attribute different?

Hope Roland will setup new draft schema soon and include all commendation into.

John, if we reach consensus on new schema, are you be able to patch sources
before code freeze on Jan 16???

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

A bunch of this stuff is covered by recent comments in 118454; let's try and
sort out some of the issues of philsophy and direction mentioned there before we
start checking in new attributes.

Comment 9

[Chan Min Wai]

This is something very similar to bug 116692 ...
hum...

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

*** This bug has been marked as a duplicate of 157925 ***