Cancelling add-on installation shows compatibility error dialog

VERIFIED FIXED in Firefox 41

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: sebastian, Assigned: Margaret)

Tracking

(Blocks 1 bug)

42 Branch
Firefox 43
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 verified, firefox42 verified, firefox43 verified, fennec41+)

Details

Attachments

(1 attachment)

STR:
* Go to addons.mozilla.org
* Select an incompatible add-on (In this case WebODF using latest Nightly)
* Click "Add to Firefox"
* In the "Installing Add-on" dialog click on "cancel"

Screencast: http://youtu.be/x5pCsRIim6U

Expected result: Installation is cancelled, nothing should happen.

Actual result: A dialog pops up saying "ODF Viewer could not be installed because it is not compatible with Nightly 42.0a1"
This might be fallout from the error handling changes I made in bug 1170844.
Was about to log the same issue, will CC everyone
(In reply to Sebastian Kaspari (:sebastian) from comment #0)
> STR:
> * Go to addons.mozilla.org
> * Select an incompatible add-on (In this case WebODF using latest Nightly)

No need to select an incompatible add-on, any add-on will have the same behaviour, so I think this is an important issue
tracking-fennec: --- → ?
Assignee: nobody → margaret.leibovic
tracking-fennec: ? → 41+
Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian
Attachment #8650656 - Flags: review?(s.kaspari)
This logic did change with bug 1170844, but this looks like a behavior we've always had.

I checked with Mossop, and he said that desktop shows a notification with an option to restart the add-on download, but given our simplified mobile UX, I think showing no extra dialog is a perfectly reasonable UX (the user did choose "cancel", after all).

I'll just double check with antlam to make sure he agrees with this idea. antlam, to clarify the situation: right now when the user chooses "Cancel" in the add-on install dialog, we show an "incompatible add-on" error message, which is just totally wrong. I propose that we just show no additional dialog in this case, since the user chose to cancel the add-on download.
Flags: needinfo?(alam)
Comment on attachment 8650656 [details]
MozReview Request: Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian

https://reviewboard.mozilla.org/r/16661/#review14987

Oh, this was easy. :)
Attachment #8650656 - Flags: review?(s.kaspari) → review+
(In reply to :Margaret Leibovic from comment #5)
> This logic did change with bug 1170844, but this looks like a behavior we've
> always had.
> 
> I checked with Mossop, and he said that desktop shows a notification with an
> option to restart the add-on download, but given our simplified mobile UX, I
> think showing no extra dialog is a perfectly reasonable UX (the user did
> choose "cancel", after all).
> 
> I'll just double check with antlam to make sure he agrees with this idea.
> antlam, to clarify the situation: right now when the user chooses "Cancel"
> in the add-on install dialog, we show an "incompatible add-on" error
> message, which is just totally wrong. I propose that we just show no
> additional dialog in this case, since the user chose to cancel the add-on
> download.

Yeah, I completely agree here. It's weird to show "incompatible" when the user already decided to "cancel" their decision.
Flags: needinfo?(alam)
https://hg.mozilla.org/integration/fx-team/rev/6012f4bbe2a973c4246e527889079392a2e48f9c
Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian
Comment on attachment 8650656 [details]
MozReview Request: Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: none
[User impact if declined]: confusing incorrect error dialog appears when user cancels an add-on install
[Describe test coverage new/current, TreeHerder]: no automated test coverage, tested locally
[Risks and why]: low-risk, small change to prevent showing an error dialog
[String/UUID change made/needed]: none
Attachment #8650656 - Flags: approval-mozilla-beta?
Attachment #8650656 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/6012f4bbe2a9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Verified as fixed on latest Nightly
Comment on attachment 8650656 [details]
MozReview Request: Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian

Patch was verified, Aurora42+, Beta41+.
Attachment #8650656 - Flags: approval-mozilla-beta?
Attachment #8650656 - Flags: approval-mozilla-beta+
Attachment #8650656 - Flags: approval-mozilla-aurora?
Attachment #8650656 - Flags: approval-mozilla-aurora+
Verifying as fixed on Firefox 41.0b6 and latest Aurora.
Status: RESOLVED → VERIFIED
Depends on: 1201547
You need to log in before you can comment on or make changes to this bug.