1185927 - Cancelling add-on installation shows compatibility error dialog

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

STR:
* Go to addons.mozilla.org
* Select an incompatible add-on (In this case WebODF using latest Nightly)
* Click "Add to Firefox"
* In the "Installing Add-on" dialog click on "cancel"

Screencast: http://youtu.be/x5pCsRIim6U

Expected result: Installation is cancelled, nothing should happen.

Actual result: A dialog pops up saying "ODF Viewer could not be installed because it is not compatible with Nightly 42.0a1"

Comment 1

[:Margaret Leibovic]

This might be fallout from the error handling changes I made in bug 1170844.

Comment 2

[u421692]

Was about to log the same issue, will CC everyone

Comment 3

[u421692]

(In reply to Sebastian Kaspari (:sebastian) from comment #0)
> STR:
> * Go to addons.mozilla.org
> * Select an incompatible add-on (In this case WebODF using latest Nightly)

No need to select an incompatible add-on, any add-on will have the same behaviour, so I think this is an important issue

Comment 4

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian

Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian

Comment 5

[:Margaret Leibovic]

This logic did change with bug 1170844, but this looks like a behavior we've always had.

I checked with Mossop, and he said that desktop shows a notification with an option to restart the add-on download, but given our simplified mobile UX, I think showing no extra dialog is a perfectly reasonable UX (the user did choose "cancel", after all).

I'll just double check with antlam to make sure he agrees with this idea. antlam, to clarify the situation: right now when the user chooses "Cancel" in the add-on install dialog, we show an "incompatible add-on" error message, which is just totally wrong. I propose that we just show no additional dialog in this case, since the user chose to cancel the add-on download.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8650656 [details]
MozReview Request: Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian

https://reviewboard.mozilla.org/r/16661/#review14987

Oh, this was easy. :)

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to :Margaret Leibovic from comment #5)
> This logic did change with bug 1170844, but this looks like a behavior we've
> always had.
> 
> I checked with Mossop, and he said that desktop shows a notification with an
> option to restart the add-on download, but given our simplified mobile UX, I
> think showing no extra dialog is a perfectly reasonable UX (the user did
> choose "cancel", after all).
> 
> I'll just double check with antlam to make sure he agrees with this idea.
> antlam, to clarify the situation: right now when the user chooses "Cancel"
> in the add-on install dialog, we show an "incompatible add-on" error
> message, which is just totally wrong. I propose that we just show no
> additional dialog in this case, since the user chose to cancel the add-on
> download.

Yeah, I completely agree here. It's weird to show "incompatible" when the user already decided to "cancel" their decision.

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/6012f4bbe2a973c4246e527889079392a2e48f9c
Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian

Comment 9

[:Margaret Leibovic]

Comment on attachment 8650656 [details]
MozReview Request: Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: none
[User impact if declined]: confusing incorrect error dialog appears when user cancels an add-on install
[Describe test coverage new/current, TreeHerder]: no automated test coverage, tested locally
[Risks and why]: low-risk, small change to prevent showing an error dialog
[String/UUID change made/needed]: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6012f4bbe2a9

Comment 11

[u421692]

Verified as fixed on latest Nightly

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8650656 [details]
MozReview Request: Bug 1185927 - Don't show extra dialog when user cancels add-on download. r=sebastian

Patch was verified, Aurora42+, Beta41+.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/443bedd065f6

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7699939b79e6

Comment 15

[Catalin Suciu [:csuciu]]

Verifying as fixed on Firefox 41.0b6 and latest Aurora.