1186015 - [IMM] nsIMM32Handler should be renamed to mozilla::widget::IMMHandler

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that we should rename nsIMM32Handler to mozilla::widget::IMMHandler (or something).

I think that "32" is redundant, we can drop it from the name. If you have better name idea, let me know.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5274bcfc3a29

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 Rename nsIMEContext to mozilla::widget::IMEContext

Replacing as:

nsIMEContext -> mozilla::widget::IMEContext
IMEContext -> context
aIMEContext -> aContext

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Rename nsIMM32Handler to mozilla::widget::IMMHandler

Renaming nsIMM32Handler.* to IMMHandler.*.

Replacing as:

nsIMM32Handler -> mozilla::widget::IMMHandler
gIMM32Handler -> gIMMHandler
gIMM32Log -> gIMMLog

And cleaning up the logs with new names.

However, this does NOT change log module name because other developers (including IME vendors) may not be familiar with our internal changes.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8637132 [details] [diff] [review]
part.1 Rename nsIMEContext to mozilla::widget::IMEContext

Review of attachment 8637132 [details] [diff] [review]:
-----------------------------------------------------------------

nice, thanks. These changes are tedious to do.

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8637150 [details] [diff] [review]
part.2 Rename nsIMM32Handler to mozilla::widget::IMMHandler

Review of attachment 8637150 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/IMMHandler.cpp
@@ +153,5 @@
> +    AppendLiteral("result str=\"");
> +    Append(
> +      NS_ConvertUTF16toUTF8(
> +        nsDependentString((char16_t*)((char*)(aReconv) + aReconv->dwStrOffset),
> +                          aReconv->dwStrLen)).get());

Use AppendUTF16toUTF8 instead Append(NS_COnvertUTF16toUTF8...)

Comment 6

[Makoto Kato [:m_kato]]

Ah, please ignore the previous review comment.  This class was based on nsString.  r=me.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/356a70e70a377e0c3703daeb656bee3a67397a4f
changeset:  356a70e70a377e0c3703daeb656bee3a67397a4f
user:       Masayuki Nakano <[e-mail]>
date:       Thu Jul 23 12:31:28 2015 +0900
description:
Bug 1186015 part.1 Rename nsIMEContext to mozilla::widget::IMEContext r=jimm

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6dfb8110796042e27a833bebbdb5ec58bf83fe2c
changeset:  6dfb8110796042e27a833bebbdb5ec58bf83fe2c
user:       Masayuki Nakano <[e-mail]>
date:       Thu Jul 23 12:31:28 2015 +0900
description:
Bug 1186015 part.2 Rename nsIMM32Handler to mozilla::widget::IMMHandler r=jimm+m_kato

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/356a70e70a37
https://hg.mozilla.org/mozilla-central/rev/6dfb81107960