Closed Bug 1186015 Opened 4 years ago Closed 4 years ago

[IMM] nsIMM32Handler should be renamed to mozilla::widget::IMMHandler

Categories

(Core :: Widget: Win32, enhancement)

x86
Windows
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(2 files)

I think that we should rename nsIMM32Handler to mozilla::widget::IMMHandler (or something).

I think that "32" is redundant, we can drop it from the name. If you have better name idea, let me know.
Replacing as:

nsIMEContext -> mozilla::widget::IMEContext
IMEContext -> context
aIMEContext -> aContext
Attachment #8637132 - Flags: review?(jmathies)
Renaming nsIMM32Handler.* to IMMHandler.*.

Replacing as:

nsIMM32Handler -> mozilla::widget::IMMHandler
gIMM32Handler -> gIMMHandler
gIMM32Log -> gIMMLog

And cleaning up the logs with new names.

However, this does NOT change log module name because other developers (including IME vendors) may not be familiar with our internal changes.
Attachment #8637150 - Flags: review?(m_kato)
Attachment #8637150 - Flags: review?(jmathies)
Comment on attachment 8637132 [details] [diff] [review]
part.1 Rename nsIMEContext to mozilla::widget::IMEContext

Review of attachment 8637132 [details] [diff] [review]:
-----------------------------------------------------------------

nice, thanks. These changes are tedious to do.
Attachment #8637132 - Flags: review?(jmathies) → review+
Attachment #8637150 - Flags: review?(jmathies) → review+
Comment on attachment 8637150 [details] [diff] [review]
part.2 Rename nsIMM32Handler to mozilla::widget::IMMHandler

Review of attachment 8637150 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/IMMHandler.cpp
@@ +153,5 @@
> +    AppendLiteral("result str=\"");
> +    Append(
> +      NS_ConvertUTF16toUTF8(
> +        nsDependentString((char16_t*)((char*)(aReconv) + aReconv->dwStrOffset),
> +                          aReconv->dwStrLen)).get());

Use AppendUTF16toUTF8 instead Append(NS_COnvertUTF16toUTF8...)
Attachment #8637150 - Flags: review?(m_kato) → review+
Ah, please ignore the previous review comment.  This class was based on nsString.  r=me.
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/356a70e70a377e0c3703daeb656bee3a67397a4f
changeset:  356a70e70a377e0c3703daeb656bee3a67397a4f
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Thu Jul 23 12:31:28 2015 +0900
description:
Bug 1186015 part.1 Rename nsIMEContext to mozilla::widget::IMEContext r=jimm

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6dfb8110796042e27a833bebbdb5ec58bf83fe2c
changeset:  6dfb8110796042e27a833bebbdb5ec58bf83fe2c
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Thu Jul 23 12:31:28 2015 +0900
description:
Bug 1186015 part.2 Rename nsIMM32Handler to mozilla::widget::IMMHandler r=jimm+m_kato
https://hg.mozilla.org/mozilla-central/rev/356a70e70a37
https://hg.mozilla.org/mozilla-central/rev/6dfb81107960
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Depends on: 1217275
You need to log in before you can comment on or make changes to this bug.