Closed Bug 1186020 Opened 4 years ago Closed 4 years ago

Download icon is very dark

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox40 --- wontfix
firefox41 --- wontfix
firefox42 --- fixed
firefox43 --- verified
fennec 42+ ---

People

(Reporter: blassey, Assigned: mcomella)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Attached image 2015-07-21 14.47.52.png
No description provided.
Flags: needinfo?(alam)
I'm seeing these icons as white and sharp on my Nexus 6, today's Nightly. Not sure what's happening here..
Flags: needinfo?(alam)
Looks OK on Nexus 4 running 5.1
Brad is using a Samsung Galaxy S6 active
4K display? Upscaling?
tracking-fennec: ? → 42+
Mike or Martyn, can one of you look into this?
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(mhaigh)
Brad, do you see this all of the time? Does the "Download complete" icon also look dark?
Assignee: nobody → michael.l.comella
Flags: needinfo?(michael.l.comella) → needinfo?(blassey.bugs)
(In reply to Michael Comella (:mcomella) from comment #6)
> Brad, do you see this all of the time? 
Yes
> Does the "Download complete" icon
> also look dark?

No
Flags: needinfo?(blassey.bugs)
Cristina, does Softvision have a Galaxy S6 and can repro this?
Flags: needinfo?(cristina.madaras)
So the resources we have are dark [1] like Brad's screenshot – I guess the tinting we (or the system?) do is going wrong.

[1]: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-xhdpi/alert_download_animation_1.png
I'm able to reproduce this issue on all current channels on Galaxy Note 3 with Android 4.4.2
Flags: needinfo?(cristina.madaras)
File revision history implies these icons were never changed beyond compression [1]. I think it was Android L (or ICS) that made the notification icons white (as opposed to some shade of gray, as it seems from googling and looking at pictures of 2.3). I wonder if these icons have just been left this way for a while.

On some L+ devices, I think I've seen Android tint all the notification icons white automatically but perhaps some devices (e.g. Brad's device) does not do this.

My solution would be to change all of the current assets to white assets.

Anthony, is there ever a time where the download animation icons (e.g. [2]) should not be white?

[1]: http://hg.mozilla.org/mozilla-central/filelog/fea87cbeaa6b/mobile/android/base/resources/drawable-xhdpi/alert_download_animation_1.png
[2]: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-xhdpi/alert_download_animation_1.png
Flags: needinfo?(alam)
A time in the frame by frame animation? I don't think so. They should probably just be white & opaque as they move.
Flags: needinfo?(alam)
We'll probably have the same problem for alert_app_animation – I filed bug 1199015.
Bug 1186020 - Convert download animation icons to white. r=liuche

To do this, I ran:
  convert <image> -alpha extract -alpha on <image>

The resultant images were slightly larger than their previous
counterparts so I then compressed them with ImageOptim.
Attachment #8653171 - Flags: review?(liuche)
Note: I'm a little concerned the notifications on GB shouldn't be white but I'd rather save everyone space than ship two sets of icons.
Flags: needinfo?(mhaigh)
Comment on attachment 8653171 [details]
MozReview Request: Bug 1186020 - Convert download animation icons to white. r=liuche

https://reviewboard.mozilla.org/r/17389/#review16197
Attachment #8653171 - Flags: review?(liuche) → review+
Comment on attachment 8653171 [details]
MozReview Request: Bug 1186020 - Convert download animation icons to white. r=liuche

Approval Request Comment
[Feature/regressing bug #]: Presumably when the download animation was first implemented

[User impact if declined]: Users on some devices have their notifications appear grey, a color inconsistent with the latest versions of the Android platform.

[Describe test coverage new/current, TreeHerder]: Tested locally (did not test GB)

[Risks and why]: Low – this is an asset swap. Biggest problem is that the notifications are not consistent with GB, but I'd rather not ship two sets of icons anyway. We'll see what the response is from GB users.

[String/UUID change made/needed]: None
Attachment #8653171 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/aaddb4b5374d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Verified as fixed using:
Device: Moto X (Android 4.4)
Build: Firefox for Android  43.0a1 (2015-09-06)
Attachment #8653171 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed using:
Device: LG G4 (Android 5.1)
Build: Firefox for Android 43.0a2 (2015-09-22)
You need to log in before you can comment on or make changes to this bug.