1186020 - Download icon is very dark

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: 2015-07-21 14.47.52.png

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I'm seeing these icons as white and sharp on my Nexus 6, today's Nightly. Not sure what's happening here..

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: fennec-system-icons.png (Nexus 4 running 5.1)

Looks OK on Nexus 4 running 5.1

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Brad is using a Samsung Galaxy S6 active

Comment 4

[Richard Newman [:rnewman]]

4K display? Upscaling?

Comment 5

[:Margaret Leibovic]

Mike or Martyn, can one of you look into this?

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Brad, do you see this all of the time? Does the "Download complete" icon also look dark?

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Michael Comella (:mcomella) from comment #6)
> Brad, do you see this all of the time? 
Yes
> Does the "Download complete" icon
> also look dark?

No

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Cristina, does Softvision have a Galaxy S6 and can repro this?

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

So the resources we have are dark [1] like Brad's screenshot – I guess the tinting we (or the system?) do is going wrong.

[1]: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-xhdpi/alert_download_animation_1.png

Comment 10

[Catalin Suciu [:csuciu]]

Attachment: Screenshot_2015-08-24-12-11-05.png

I'm able to reproduce this issue on all current channels on Galaxy Note 3 with Android 4.4.2

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

File revision history implies these icons were never changed beyond compression [1]. I think it was Android L (or ICS) that made the notification icons white (as opposed to some shade of gray, as it seems from googling and looking at pictures of 2.3). I wonder if these icons have just been left this way for a while.

On some L+ devices, I think I've seen Android tint all the notification icons white automatically but perhaps some devices (e.g. Brad's device) does not do this.

My solution would be to change all of the current assets to white assets.

Anthony, is there ever a time where the download animation icons (e.g. [2]) should not be white?

[1]: http://hg.mozilla.org/mozilla-central/filelog/fea87cbeaa6b/mobile/android/base/resources/drawable-xhdpi/alert_download_animation_1.png
[2]: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-xhdpi/alert_download_animation_1.png

Comment 12

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

A time in the frame by frame animation? I don't think so. They should probably just be white & opaque as they move.

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We'll probably have the same problem for alert_app_animation – I filed bug 1199015.

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1186020 - Convert download animation icons to white. r=liuche

Bug 1186020 - Convert download animation icons to white. r=liuche

To do this, I ran:
  convert <image> -alpha extract -alpha on <image>

The resultant images were slightly larger than their previous
counterparts so I then compressed them with ImageOptim.

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Note: I'm a little concerned the notifications on GB shouldn't be white but I'd rather save everyone space than ship two sets of icons.

Comment 16

[Chenxia Liu [:liuche]]

Comment on attachment 8653171 [details]
MozReview Request: Bug 1186020 - Convert download animation icons to white. r=liuche

https://reviewboard.mozilla.org/r/17389/#review16197

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/aaddb4b5374d

Comment 18

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8653171 [details]
MozReview Request: Bug 1186020 - Convert download animation icons to white. r=liuche

Approval Request Comment
[Feature/regressing bug #]: Presumably when the download animation was first implemented

[User impact if declined]: Users on some devices have their notifications appear grey, a color inconsistent with the latest versions of the Android platform.

[Describe test coverage new/current, TreeHerder]: Tested locally (did not test GB)

[Risks and why]: Low – this is an asset swap. Biggest problem is that the notifications are not consistent with GB, but I'd rather not ship two sets of icons anyway. We'll see what the response is from GB users.

[String/UUID change made/needed]: None

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aaddb4b5374d

Comment 20

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-09-07-12-59-23.png

Verified as fixed using:
Device: Moto X (Android 4.4)
Build: Firefox for Android  43.0a1 (2015-09-06)

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/99be82d7ce88

Comment 22

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-09-24-15-09-29.png

Verified as fixed using:
Device: LG G4 (Android 5.1)
Build: Firefox for Android 43.0a2 (2015-09-22)