1186042 - "Undeclared identifier" errors building nsAboutBloat.cpp

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

In file included from /usr/local/src/Mozilla/mozilla-central/obj-firefox-64bit/netwerk/protocol/about/Unified_cpp_protocol_about0.cpp:11:
/usr/local/src/Mozilla/mozilla-central/netwerk/protocol/about/nsAboutBloat.cpp:94:9: error: unknown type name 'PRExplodedTime'
        PRExplodedTime expTime;
        ^
libother-licenses_snappy.a.desc
rm -f libother-licenses_snappy.a
/usr/local/src/Mozilla/mozilla-central/netwerk/protocol/about/nsAboutBloat.cpp:95:24: error: use of undeclared identifier 'PR_Now'; did you mean 'JS_Now'?
        PR_ExplodeTime(PR_Now(), PR_LocalTimeParameters, &expTime);
                       ^~~~~~
                       JS_Now
../../../dist/include/jsapi.h:937:1: note: 'JS_Now' declared here
JS_Now(void);
^
/usr/local/src/Mozilla/mozilla-central/obj-firefox-64bit/_virtualenv/bin/python /usr/local/src/Mozilla/mozilla-central/config/expandlibs_gen.py -o libother-licenses_snappy.a.desc Unified_cpp_snappy0.o  
In file included from /usr/local/src/Mozilla/mozilla-central/obj-firefox-64bit/netwerk/protocol/about/Unified_cpp_protocol_about0.cpp:11:
/usr/local/src/Mozilla/mozilla-central/netwerk/protocol/about/nsAboutBloat.cpp:95:34: error: use of undeclared identifier 'PR_LocalTimeParameters'
        PR_ExplodeTime(PR_Now(), PR_LocalTimeParameters, &expTime);

I see these on the Mac, doing my own self builds.  But I expect they can happen on all platforms.  I have no idea why this bug hasn't broken Mozilla's own m-c nightly builds -- it really should have.

This bug was triggered by the patches for bug 905127.

The fix is very simple.  I'll post it in my next comment.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Attachment: Fix

Apparently bug 905127 changed nsNetUtil.h so that it no longer includes prtime.h, even indirectly.  But all we need is prtime.h, so we should just include that directly.

Comment 2

[Josh Matthews [:jdm]]

Are you using non-unified builds, by chance?

Comment 3

[Steven Michaud [:smichaud] (Retired)]

I see the same errors whether nsAboutBloat.cpp is part of a unified build or not.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

I didn't try disabling unified builds altogether, though.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f6ebeef9b8c

Comment 6

[Steven Michaud [:smichaud] (Retired)]

But yes, I see how using unified builds might have papered over this bug.

I suppose we should do totally non-unified builds periodically on our official build machines, just to uncover bugs like this.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

Another thing:  Almost all my builds are from-scratch.  That my be why I always saw this bug.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f6ebeef9b8c