1186115 - [pulsetranslator] Expose 'testPackagesUrl' buildbot property

Status: RESOLVED FIXED

(Webtools :: Pulse, defect)

Description

[Andrew Halberstadt [:ahal]]

Bug 917999 refactored tests.zip into several smaller packages. This breaks the testsurl property set by pulsetranslator:
https://github.com/mozilla/pulsetranslator/blob/master/pulsetranslator/pulsetranslator.py#L267

I'm not sure what we should do instead, I guess we'll want a dict or list of all the new test urls?

This broke the old test-informant service which was still chugging along until June 30th. I don't think it's worth fixing test-informant, but we should probably fix pulsetranslator at least.

Comment 1

[Andrew Halberstadt [:ahal]]

Oh, just noticed there's a new 'testPackagesURL' buildbot prop that points to a file like this:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux/1437501111/test_packages.json

We can just forward that instead of testsurl. Would be more convenient to have the contents of that file directly in the pulse data, but probably not worth the extra overhead.

Comment 2

[Andrew Halberstadt [:ahal]]

Bah, testsUrl is still there, just not on unittest.# (which is what I was looking at via pulse-inspector. Confusingly the property exists on unittest.#, but is set to None.

Anyway, we should still expose that test_packages.json file via pulse translator though, I'll morph the bug to do that.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Expose testPackagesUrl

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8636714 [details] [review]
Expose testPackagesUrl

lgtm, thanks for noticing and fixing this

Comment 5

[Andrew Halberstadt [:ahal]]

https://github.com/mozilla/pulsetranslator/commit/4ed45a71bfeda95cf20aa0cfda888c8e4fa070e5

Comment 6

[Jonathan Griffin (:jgriffin)]

...and deployed.