Closed Bug 1186115 Opened 5 years ago Closed 5 years ago

[pulsetranslator] Expose 'testPackagesUrl' buildbot property

Categories

(Webtools :: Pulse, defect)

defect
Not set

Tracking

(firefox42 affected)

RESOLVED FIXED
Tracking Status
firefox42 --- affected

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

50 bytes, text/x-github-pull-request
jgriffin
: review+
Details | Review
Bug 917999 refactored tests.zip into several smaller packages. This breaks the testsurl property set by pulsetranslator:
https://github.com/mozilla/pulsetranslator/blob/master/pulsetranslator/pulsetranslator.py#L267

I'm not sure what we should do instead, I guess we'll want a dict or list of all the new test urls?

This broke the old test-informant service which was still chugging along until June 30th. I don't think it's worth fixing test-informant, but we should probably fix pulsetranslator at least.
Oh, just noticed there's a new 'testPackagesURL' buildbot prop that points to a file like this:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux/1437501111/test_packages.json

We can just forward that instead of testsurl. Would be more convenient to have the contents of that file directly in the pulse data, but probably not worth the extra overhead.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Bah, testsUrl is still there, just not on unittest.# (which is what I was looking at via pulse-inspector. Confusingly the property exists on unittest.#, but is set to None.

Anyway, we should still expose that test_packages.json file via pulse translator though, I'll morph the bug to do that.
Summary: [pulsetranslator] testsurl is null after test package refactoring → [pulsetranslator] Expose 'testPackagesUrl' buildbot property
Attached file Expose testPackagesUrl
Attachment #8636714 - Flags: review?(jgriffin)
Comment on attachment 8636714 [details] [review]
Expose testPackagesUrl

lgtm, thanks for noticing and fixing this
Attachment #8636714 - Flags: review?(jgriffin) → review+
https://github.com/mozilla/pulsetranslator/commit/4ed45a71bfeda95cf20aa0cfda888c8e4fa070e5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
...and deployed.
You need to log in before you can comment on or make changes to this bug.