1186148 - Top sites crash on orientation change

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Go to home panel in landscape orientation.
2) Switch to any panel, then switch back to Top Sites panel.
3) Rotate to portrait orientation. Crash.


2015-07-21 12:49:24.213 Client[42754:1126909] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'UICollectionView received layout attributes for a cell with an index path that does not exist: <NSIndexPath: 0xc000000000050016> {length = 2, path = 0 - 10}'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000010d7bcc65 __exceptionPreprocess + 165
	1   libobjc.A.dylib                     0x000000010cce4bb7 objc_exception_throw + 45
	2   CoreFoundation                      0x000000010d7bcaca +[NSException raise:format:arguments:] + 106
	3   Foundation                          0x000000010c8f998f -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 195
	4   UIKit                               0x000000010eaf468b __45-[UICollectionViewData validateLayoutInRect:]_block_invoke + 1125
	5   UIKit                               0x000000010eaf3d9d -[UICollectionViewData validateLayoutInRect:] + 3092
	6   UIKit                               0x000000010eab7850 -[UICollectionView layoutSubviews] + 194
	7   UIKit                               0x000000010e5139eb -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 536
	8   QuartzCore                          0x000000010e30eed2 -[CALayer layoutSublayers] + 146
	9   QuartzCore                          0x000000010e3036e6 _ZN2CA5Layer16layout_if_neededEPNS_11TransactionE + 380
	10  UIKit                               0x000000010e507635 -[UIView(Hierarchy) layoutBelowIfNeeded] + 607
	11  Client                              0x000000010b3c1641 _TFFC6Client26BrowserScrollingControllerP33_E895B1F507DC54D28079C32F81477EEE26animateToolbarsWithOffsetsFS0_FT8animatedSb8durationSd12headerOffsetV12CoreGraphics7CGFloat12footerOffsetS2_5alphaS2_10completionGSqFT8finishedSb_T___T_U_FT_T_ + 529
	12  Client                              0x000000010b28ec2c _TFC6Client26BrowserScrollingControllerP33_E895B1F507DC54D28079C32F81477EEE26animateToolbarsWithOffsetsfS0_FT8animatedSb8durationSd12headerOffsetV12CoreGraphics7CGFloat12footerOffsetS2_5alphaS2_10completionGSqFT8finishedSb_T___T_ + 1180
	13  Client                              0x000000010b28e747 _TFC6Client26BrowserScrollingController12showToolbarsfS0_FT8animatedSb10completionGSqFT8finishedSb_T___T_ + 439
	14  Client                              0x000000010b30b26d _TFC6Client21BrowserViewController27SELstatusBarFrameWillChangefS0_FCSo14NSNotificationT_ + 941
	15  Client                              0x000000010b30b37a _TToFC6Client21BrowserViewController27SELstatusBarFrameWillChangefS0_FCSo14NSNotificationT_ + 58
	16  CoreFoundation                      0x000000010d78c54c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
	17  CoreFoundation                      0x000000010d68aa04 _CFXNotificationPost + 2484
	18  Foundation                          0x000000010c83b968 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
	19  UIKit                               0x000000010e4965dc -[UIApplication setStatusBarOrientation:animationParameters:notifySpringBoardAndFence:] + 529
	20  UIKit                               0x000000010e4e7235 __78-[UIWindow _rotateWindowToOrientation:updateStatusBar:duration:skipCallbacks:]_block_invoke1072 + 284
	21  UIKit                               0x000000010e90c100 __58-[_UIWindowRotationAnimationController animateTransition:]_block_invoke + 44
	22  UIKit                               0x000000010e50c3e2 +[UIView(UIViewAnimationWithBlocks) _setupAnimationWithDuration:delay:view:options:factory:animations:start:animationStateGenerator:completion:] + 473
	23  UIKit                               0x000000010e50c637 +[UIView(UIViewAnimationWithBlocks) animateWithDuration:delay:options:animations:completion:] + 57
	24  UIKit                               0x000000010e90c090 -[_UIWindowRotationAnimationController animateTransition:] + 408
	25  UIKit                               0x000000010e4e4a09 -[UIWindow _rotateToBounds:withAnimator:transitionContext:] + 761
	26  UIKit                               0x000000010e4e6c77 -[UIWindow _rotateWindowToOrientation:updateStatusBar:duration:skipCallbacks:] + 1741
	27  UIKit                               0x000000010e4e75ba -[UIWindow _setRotatableClient:toOrientation:applyTransformToWindow:updateStatusBar:duration:force:isRotating:] + 559
	28  UIKit                               0x000000010e4e652e -[UIWindow _setRotatableClient:toOrientation:updateStatusBar:duration:force:isRotating:] + 116
	29  UIKit                               0x000000010e4e64b4 -[UIWindow _setRotatableClient:toOrientation:updateStatusBar:duration:force:] + 36
	30  UIKit                               0x000000010e4e6361 -[UIWindow _setRotatableViewOrientation:updateStatusBar:duration:force:] + 122
	31  UIKit                               0x000000010e4e53fe __57-[UIWindow _updateToInterfaceOrientation:duration:force:]_block_invoke + 98
	32  UIKit                               0x000000010e4e534e -[UIWindow _updateToInterfaceOrientation:duration:force:] + 391
	33  UIKit                               0x000000010e4e5790 -[UIWindow _updateInterfaceOrientationFromDeviceOrientation:] + 316
	34  CoreFoundation                      0x000000010d78c54c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
	35  CoreFoundation                      0x000000010d68aa04 _CFXNotificationPost + 2484
	36  Foundation                          0x000000010c83b968 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
	37  UIKit                               0x000000010e70ce19 -[UIDevice setOrientation:animated:] + 282
	38  UIKit                               0x000000010e4a8007 -[UIApplication handleEvent:withNewEvent:] + 1507
	39  UIKit                               0x000000010e4a849a -[UIApplication sendEvent:] + 79
	40  UIKit                               0x000000010e493b4f _UIApplicationHandleEvent + 593
	41  GraphicsServices                    0x000000011177638c _PurpleEventCallback + 756
	42  GraphicsServices                    0x0000000111775e74 PurpleEventCallback + 35
	43  CoreFoundation                      0x000000010d6f06a9 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 41
	44  CoreFoundation                      0x000000010d6f061b __CFRunLoopDoSource1 + 475
	45  CoreFoundation                      0x000000010d6e5e68 __CFRunLoopRun + 2200
	46  CoreFoundation                      0x000000010d6e5366 CFRunLoopRunSpecific + 470
	47  GraphicsServices                    0x0000000111774a3e GSEventRunModal + 161
	48  UIKit                               0x000000010e4938c0 UIApplicationMain + 1282
	49  Client                              0x000000010b1f8b47 main + 1047
	50  libdyld.dylib                       0x00000001106ef145 start + 1
)

Comment 1

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8638521 [details] [review]
Pull request

Left some comments on the PR

Comment 3

[Bryan Munar (:bkmunar)]

Fixed!! :)