1186254 - [meta] linkifier edge cases and bugs

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

The text chat linkifier will be landing in bug 1176280.  Once that's done, there are a number of user-experience rough-edges that we'll want to triage.  There are a couple of classes of these:

* things that are part of the skippedTests block in linkifiedTextView_test.js

* the list of tests in Autolinker.js that seem worth porting but haven't been.

Some of these will want to live in the existing tests for render, but I suspect many of them will really want to be pushed down into unit tests for the LinkifiedTextParser, particularly as that gets broken up into smaller methods.
They could conceivably live both places, I suppose.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Here are the key failing bits in the linkifier.  I've added my comments with a * in front of them.

RT, 41 is the release where text chat is going out, correct?

Secondly, do you agree that we can live without all of these and that I should request uplift on the linkifier code as is to 41 (I hope to do this Friday so that we don't have to uplift twice)?

They should all be split out into separate bugs and put in the backlog; I've listed them in what I believe should be their priority order:

should linkify google.com without a preceding http://
* we want this, it's likely to be some work; already split out as bug 1186245

should not include a ? or other likely punctuation characters
should linkify 'check out http://example.com/monkey.', w/o trailing dots
* Eg "have you seen http://google.com?" includes the ? at the end of the link as part of the link.  Valid URLs may end in various symbols, but do so relatively rarely.  In those cases, if the typist has those URLs in a sentence, they will work. However, people sometimes (not sure how often) include them, intending them to be linguistic punctation.  I suspect we want to error in favor of likely human intent, and away from strict URL compliance.

bug 1186245 (linkify stuff without http:// or https://) 

should linkify http://localhost URLs
* Developers are likely to use http://localhost URLs, most other folks aren't.

should linkify HTML with nested tags and a resource path properly escaped
* This is only interesting to developers who paste HTML around

Comment 2

[Romain Testard [:RT]]

Yes, chat will follow the 41 train and the linkifier code should be uplifted to 41.

(In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment #1)
> Here are the key failing bits in the linkifier.  I've added my comments with
> a * in front of them.
> 
> RT, 41 is the release where text chat is going out, correct?
> 
Yes
> Secondly, do you agree that we can live without all of these and that I
> should request uplift on the linkifier code as is to 41 (I hope to do this
> Friday so that we don't have to uplift twice)?
> 
Agreed, the linkifier code should be uplifted to 41.
The list and order below look good!

> They should all be split out into separate bugs and put in the backlog; I've
> listed them in what I believe should be their priority order:
> 
> should linkify google.com without a preceding http://
> * we want this, it's likely to be some work; already split out as bug 1186245
> 
> should not include a ? or other likely punctuation characters
> should linkify 'check out http://example.com/monkey.', w/o trailing dots
> * Eg "have you seen http://google.com?" includes the ? at the end of the
> link as part of the link.  Valid URLs may end in various symbols, but do so
> relatively rarely.  In those cases, if the typist has those URLs in a
> sentence, they will work. However, people sometimes (not sure how often)
> include them, intending them to be linguistic punctation.  I suspect we want
> to error in favor of likely human intent, and away from strict URL
> compliance.
> 
> bug 1186245 (linkify stuff without http:// or https://) 
> 
> should linkify http://localhost URLs
> * Developers are likely to use http://localhost URLs, most other folks
> aren't.
> 
> should linkify HTML with nested tags and a resource path properly escaped
> * This is only interesting to developers who paste HTML around

Comment 3

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.