1186313 - Long press on content editable area and got a JS type error in text_selection_dialog.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Boris Chiou [:boris]]

When I try to long press on a content editable area, I got this error message:
GeckoConsole: [JavaScript Error: "TypeError: this.elements is undefined" {file: "app://system.gaiamobile.org/js/text_selection_dialog.js" line: 415}

Therefore, I cannot see the cut/copy/paste dialog after I select "copy image"/"copy link" on browser_context_menu from other apps. This only happens after I restart the flame. If the dialog appears once, everything looks good to me.

Comment 1

[Boris Chiou [:boris]]

Sorry, I should explain this problem more clearly:
Instead of copying from the bubble dialog, I copy images/links by context menu, and then paste directly on a content editable area. In this case, I got this JS error.

(In reply to Boris Chiou [:boris] from comment #0)
> When I try to long press on a content editable area, I got this error
> message:
> GeckoConsole: [JavaScript Error: "TypeError: this.elements is undefined"
> {file: "app://system.gaiamobile.org/js/text_selection_dialog.js" line: 415}
> 
> Therefore, I cannot see the cut/copy/paste dialog after I select "copy
> image"/"copy link" on browser_context_menu from other apps. This only
> happens after I restart the flame. If the dialog appears once, everything
> looks good to me.

Comment 2

[Boris Chiou [:boris]]

Attachment: Fix intializing errors of text selection dialog

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] BorisChiou:bug1186313 > mozilla-b2g:master

Comment 4

[Boris Chiou [:boris]]

Comment on attachment 8636975 [details] [review]
[gaia] BorisChiou:bug1186313 > mozilla-b2g:master

Hi, Tim,

I fix this unit test error:
TEST-UNEXPECTED-FAIL | null | [system-test/unit/text_selection_dialog_test.js] system/TextSelectionDialog handleEven selectionstatechanged event should render when first show

In this patch, I move this.render() into this.show(), so we make sure that "first show()" must call render(). Therefore, we don't need this test case anymore.

Comment 5

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/a7d99ffc8bea851347c325be46e88fbadbb18564