Closed
Bug 1186315
Opened 10 years ago
Closed 10 years ago
Add TestTuple to test list
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: xeonchen, Assigned: xeonchen)
Details
Attachments
(1 file)
|
1.26 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
I found there's an error case in TestTuple, and it's not reported because TestTuple is not in the testing list.
| Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8636974 -
Flags: review?(nfroyd)
| Assignee | ||
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8636974 [details] [diff] [review]
Fix TestTuple error and add it into test
Review of attachment 8636974 [details] [diff] [review]:
-----------------------------------------------------------------
Uh. That's weird, because all the builders in automation say that test passes...
Attachment #8636974 -
Flags: review?(nfroyd) → review+
Comment 4•10 years ago
|
||
(In reply to Nathan Froyd [:froydnj][:nfroyd] from comment #3)
> because all the builders in automation say that test passes...
Scratch that, apparently I can't read logs. It looks like the test is not even getting executed due to this weird moz.build/cppunittests.ini split.
Comment 5•10 years ago
|
||
Sorry about that, I didn't know about cppunittests.ini. Thanks for catching this, Gary!
| Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•