Closed Bug 1186315 Opened 8 years ago Closed 8 years ago

Add TestTuple to test list

Categories

(Core :: MFBT, defect)

Product:
Core
Component:
MFBT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: xeonchen, Assigned: xeonchen)

Details

Attachments

(1 file)

Fix TestTuple error and add it into test
1.26 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
I found there's an error case in TestTuple, and it's not reported because TestTuple is not in the testing list.

        Attachment #8636974 -
        Flags: review?(nfroyd)

    
    

    
  
Comment on attachment 8636974 [details] [diff] [review]
Fix TestTuple error and add it into test

Review of attachment 8636974 [details] [diff] [review]:
-----------------------------------------------------------------

Uh.  That's weird, because all the builders in automation say that test passes...

        Attachment #8636974 -
        Flags: review?(nfroyd) → review+

    
    

    
  
(In reply to Nathan Froyd [:froydnj][:nfroyd] from comment #3)
> because all the builders in automation say that test passes...

Scratch that, apparently I can't read logs.  It looks like the test is not even getting executed due to this weird moz.build/cppunittests.ini split.

    
    

    
  
Sorry about that, I didn't know about cppunittests.ini. Thanks for catching this, Gary!

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b8d485bbedce
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox42:
          --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42

          You need to log in
          before you can comment on or make changes to this bug.