Closed Bug 1186398 Opened 9 years ago Closed 9 years ago

[e10s] close <select> element leads to open URL

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Version:
42 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox41 --- fixed
firefox42 --- fixed

People

(Reporter: over68, Assigned: enndeakin)

References

(Blocks 2 open bugs)

Details

(Keywords: regression)

Attachments

(1 file)

Fix silliness
5.74 KB, patch
Felipe
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Steps to reproduce:

1. Go to https://dl.dropboxusercontent.com/u/95157096/85f61cf7/qe0w9gfq7x.html.
2. Open the <select> element.
3. Click on the <select> element to close.


Actual results:

Close <select> element leads to open URL.
Summary: Close <select> element leads to open URL → [e10s] Close <select> element leads to open URL
Blocks: 1149745
Status: UNCONFIRMED → NEW
tracking-e10s: --- → ?
Ever confirmed: true
Blocks: fxe10s, e10s-select
Flags: needinfo?(enndeakin)
Keywords: regression
Summary: [e10s] Close <select> element leads to open URL → [e10s] close <select> element leads to open URL
I'll look at this.
Assignee: nobody → enndeakin
Flags: needinfo?(enndeakin)
Attached patch Fix silliness — — Splinter Review 
Wrong kind of brackets.
Attachment #8638695 - Flags: review?(felipc)
Points: --- → 1
Attachment #8638695 - Flags: review?(felipc) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/effb4125322895c0c7f01d8bfe7ecb99f5c3a502
changeset:  effb4125322895c0c7f01d8bfe7ecb99f5c3a502
user:       Neil Deakin <neil@mozilla.com>
date:       Mon Jul 27 07:33:55 2015 -0400
description:
Bug 1186398, perform correct check when comparing if the select value has changed, r=felipe
https://hg.mozilla.org/mozilla-central/rev/effb41253228
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Could this be uplifted to Aurora as well? Assuming I haven't made a mistake, Bug 1149745 landed during the 41 timeframe.

Sorry for not filling out the uplift template myself. The change doesn't look risky, but I'm too unfamiliar with the code to be confident.

Thanks!
status-firefox41: --- → affected
Flags: needinfo?(enndeakin)
Comment on attachment 8638695 [details] [diff] [review]
Fix silliness

Approval Request Comment
[Feature/regressing bug #]: regression from bug 1149745
[User impact if declined]: the change event on <select> elements fires at the wrong time, and will cause site compatibility issues. e10s only issue.
[Describe test coverage new/current, TreeHerder]: tested on try and has tests in patch
[Risks and why]: caused by minor typo, no real risk
[String/UUID change made/needed]: none
Flags: needinfo?(enndeakin)
Attachment #8638695 - Flags: approval-mozilla-aurora?
Comment on attachment 8638695 [details] [diff] [review]
Fix silliness

Simple change + a test, seems safe to uplift to Aurora.
Attachment #8638695 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-e10s: ? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: