Closed Bug 1186398 Opened 4 years ago Closed 4 years ago
[e10s] close <select> element leads to open URL
Steps to reproduce: 1. Go to https://dl.dropboxusercontent.com/u/95157096/85f61cf7/qe0w9gfq7x.html. 2. Open the <select> element. 3. Click on the <select> element to close. Actual results: Close <select> element leads to open URL.
Regression range (mozilla-central): https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=eaf4f9b45117&tochange=c26dbd63604d Regression range (mozilla-inbound): https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a03152790896&tochange=11373e6e556f
Summary: Close <select> element leads to open URL → [e10s] Close <select> element leads to open URL
Summary: [e10s] Close <select> element leads to open URL → [e10s] close <select> element leads to open URL
I'll look at this.
Assignee: nobody → enndeakin
Wrong kind of brackets.
Attachment #8638695 - Flags: review?(felipc)
Attachment #8638695 - Flags: review?(felipc) → review+
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/effb4125322895c0c7f01d8bfe7ecb99f5c3a502 changeset: effb4125322895c0c7f01d8bfe7ecb99f5c3a502 user: Neil Deakin <firstname.lastname@example.org> date: Mon Jul 27 07:33:55 2015 -0400 description: Bug 1186398, perform correct check when comparing if the select value has changed, r=felipe
Could this be uplifted to Aurora as well? Assuming I haven't made a mistake, Bug 1149745 landed during the 41 timeframe. Sorry for not filling out the uplift template myself. The change doesn't look risky, but I'm too unfamiliar with the code to be confident. Thanks!
Comment on attachment 8638695 [details] [diff] [review] Fix silliness Approval Request Comment [Feature/regressing bug #]: regression from bug 1149745 [User impact if declined]: the change event on <select> elements fires at the wrong time, and will cause site compatibility issues. e10s only issue. [Describe test coverage new/current, TreeHerder]: tested on try and has tests in patch [Risks and why]: caused by minor typo, no real risk [String/UUID change made/needed]: none
Attachment #8638695 - Flags: approval-mozilla-aurora?
Comment on attachment 8638695 [details] [diff] [review] Fix silliness Simple change + a test, seems safe to uplift to Aurora.
Attachment #8638695 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.