Closed Bug 1186442 Opened 6 years ago Closed 6 years ago

Remove/hide localhost references in the address-bar

Categories

(Firefox for iOS :: General, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: aaronmt, Assigned: bmunar)

Details

Attachments

(1 file)

PR
47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
This is coming up on ios-feedback, where we are showing the local server address more often than we want (for reasons we should figure out here).

Kill it.

https://groups.google.com/a/mozilla.com/d/msgid/ios-feedback/DD64D66E-2EF5-4A7E-A1EC-592854798275%40gmail.com
I see the localhost:port/errors/undefined error on tab restore where one of the tabs is about:home
I think I fixed this already? I'm reproducing it and it's not showing up for me?
https://bugzilla.mozilla.org/show_bug.cgi?id=1183806 <-- this is the bug; are you running a current build and triggering the sessionrestore?
I'm running master, ios-feedback post is on build #25.
Does it still happen?
*on master?
Any updates on this?
Yes, this is visible on tab restoration (at least for me) when an error page is in focus.

E.g, visit a non existent page (i.e, http://192.168.1.999), close browser re-open browser, see localhost error address
@Aaron, got it, ill get on it
Assignee: nobody → bmunar
Attached file PR
LOL
Attachment #8638764 - Flags: review?(bnicholson)
Comment on attachment 8638764 [details] [review]
PR

Since you don't have any description for your fix, I'm guessing what's happening is that decodeURL is returning "localhost:port/errors/undefined", which we're returning? If that's the case, we should fix decodeURL to not return that in the first place, rather than trying band-aid the code that uses the bad result.
Attachment #8638764 - Flags: review?(bnicholson) → review-
Comment on attachment 8638764 [details] [review]
PR

smiley crab
Attachment #8638764 - Flags: review- → review?(bnicholson)
Attachment #8638764 - Flags: review?(bnicholson) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.