1186442 - Remove/hide localhost references in the address-bar

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

This is coming up on ios-feedback, where we are showing the local server address more often than we want (for reasons we should figure out here).

Kill it.

https://groups.google.com/a/mozilla.com/d/msgid/ios-feedback/DD64D66E-2EF5-4A7E-A1EC-592854798275%40gmail.com

Comment 1

[Aaron Train [:aaronmt]]

I see the localhost:port/errors/undefined error on tab restore where one of the tabs is about:home

Comment 2

[Bryan Munar (:bkmunar)]

I think I fixed this already? I'm reproducing it and it's not showing up for me?

Comment 3

[Bryan Munar (:bkmunar)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1183806 <-- this is the bug; are you running a current build and triggering the sessionrestore?

Comment 4

[Aaron Train [:aaronmt]]

I'm running master, ios-feedback post is on build #25.

Comment 5

[Bryan Munar (:bkmunar)]

Does it still happen?

Comment 6

[Bryan Munar (:bkmunar)]

*on master?

Comment 7

[Bryan Munar (:bkmunar)]

Any updates on this?

Comment 8

[Aaron Train [:aaronmt]]

Yes, this is visible on tab restoration (at least for me) when an error page is in focus.

E.g, visit a non existent page (i.e, http://192.168.1.999), close browser re-open browser, see localhost error address

Comment 9

[Bryan Munar (:bkmunar)]

@Aaron, got it, ill get on it

Comment 10

[Bryan Munar (:bkmunar)]

Attachment: PR

LOL

Comment 11

[Brian Nicholson (:bnicholson)]

Comment on attachment 8638764 [details] [review]
PR

Since you don't have any description for your fix, I'm guessing what's happening is that decodeURL is returning "localhost:port/errors/undefined", which we're returning? If that's the case, we should fix decodeURL to not return that in the first place, rather than trying band-aid the code that uses the bad result.

Comment 12

[Bryan Munar (:bkmunar)]

Comment on attachment 8638764 [details] [review]
PR

smiley crab