1186497 - Update strings in about:logins edit logins

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

Description

[Allison Naaktgeboren :ally]

replace string

Comment 1

[Allison Naaktgeboren :ally]

Attachment: changededitlogintoast

Comment 2

[Allison Naaktgeboren :ally]

Attachment: string changes

I left the dtd term as editLogins.save because under the hood I have to delete and then save a new record each time there is a change, or the db barfs. So it looks like its updating to the user, but like its saving to the engineer.

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8637337 [details] [diff] [review]
string changes

Review of attachment 8637337 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with one comment addressed.

> I left the dtd term as editLogins.save because under the hood I have to
> delete and then save a new record each time there is a change, or the db
> barfs. So it looks like its updating to the user, but like its saving to the
> engineer.

I strongly disagree - the naming of a string should reflect what the *string* is, and should not be coupled with its implementation. Also, that'd be really, really confusing.

::: mobile/android/locales/en-US/chrome/aboutLogins.dtd
@@ -4,5 @@
>  <!ENTITY % brandDTD
>       SYSTEM "chrome://branding/locale/brand.dtd">
>     %brandDTD;
>  <!ENTITY aboutLogins.title                       "Logins">
> -<!ENTITY aboutLogins.save                        "Save">

Change this to aboutLogins.update. This will become confusing when we add the Save page, and the string name should match the string.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cc52b6635f5e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc52b6635f5e

Comment 6

[Francesco Lodolo [:flod]]

Considering that this bug is still open, this is not OK
http://hg.mozilla.org/mozilla-central/diff/cc52b6635f5e/mobile/android/locales/en-US/chrome/aboutLogins.properties

New string, new string ID. Can you please update? Or let me know if you want a follow-up bug.

Comment 7

[Chenxia Liu [:liuche]]

Ah, for some reason, I thought nightly-only changes were okay. This feature has been held on nightly so it's never merged to aurora (it's been kept behind a Nightly flag), but I'm happy to file a followup if you want.

Comment 8

[Francesco Lodolo [:flod]]

Once it lands in mozilla-central it's exposed to the localization process. After that, any change (unless it's a minor one) needs a new string ID, otherwise locales risk to never get updated.

Comment 9

[Matthew N. [:MattN]]

https://hg.mozilla.org/mozilla-central/rev/cc52b6635f5e

Comment 10

[Chenxia Liu [:liuche]]

Filed and landed bug 1187428.