1186523 - Normalize does not exist for UnknownProtocol

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

It doesn't implement the full account API, this is fixed (in a minimalistic way) in [1], maybe creating a real account with jsProtoHelper would be better?

Nominally setting myself as the assignee because it's easy and we should fix it, but feel free to grab this if you'd like.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=8580335&action=diff#a/chat/components/src/imAccounts.js_sec2

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch v1

A slightly more verbose version.

Comment 2

[aleth [:aleth]]

Comment on attachment 8637486 [details] [diff] [review]
Patch v1

Review of attachment 8637486 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/components/src/imAccounts.js
@@ +103,5 @@
>    get usePurpleProxy() false
>  };
>  
>  function UnknownAccountBuddy(aAccount, aBuddy, aTag) {
> +  let unknownAccount = {

Would it make more sense to do unknownaAccount.prototype = GenericAccountPrototype?

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Patch v2

Now using GenericAccountPrototype.

Comment 4

[aleth [:aleth]]

Comment on attachment 8638199 [details] [diff] [review]
Patch v2

Review of attachment 8638199 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/6962356b69b1

Comment 6

[Patrick Cloke [:clokep]]

Updating milestone from 1.6 to 42.