Closed
Bug 1186532
Opened 9 years ago
Closed 9 years ago
Add RecyclerView to Robocop builds
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(1 file, 1 obsolete file)
Writing tests for anything that touches code using RecyclerView fails the Robocop build[1]. Unfortunately Robocop uses it's own Makefile-based build configuration. Let's see how we can add the library.
[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5b8731bd40d
|
Assignee | |
Comment 1•9 years ago
|
||
This patch seems to fix it locally.
@jalmeida: Can you verify?
Attachment #8637363 -
Flags: feedback?(jalmeida)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
|
||
Comment 2•9 years ago
|
||
Wooh, it works!
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8637363 [details] [diff] [review]
robocop-recyclerview.patch
Review of attachment 8637363 [details] [diff] [review]:
-----------------------------------------------------------------
Works locally for me. Thanks!
Attachment #8637363 -
Flags: feedback?(jalmeida) → feedback+
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Jonathan Almeida [:jonalmeida] from comment #3)
> Works locally for me. Thanks!
Great! Thank you. Let's see what the try server says.
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
|
Assignee | |
Comment 6•9 years ago
|
||
Bug 1186532 - Add RecyclerView library to Robocop builds. r=jonalmeida
Attachment #8637896 -
Flags: review?(jalmeida)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8637363 -
Attachment is obsolete: true
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8637896 [details]
MozReview Request: Bug 1186532 - Add RecyclerView library to Robocop builds. r=jonalmeida
https://reviewboard.mozilla.org/r/14009/#review12529
Attachment #8637896 -
Flags: review?(jalmeida) → review+
|
|
Assignee | |
Comment 8•9 years ago
|
||
url: https://hg.mozilla.org/integration/fx-team/rev/9678bc0d71884f97e92569a2494b14111d50b7b2
changeset: 9678bc0d71884f97e92569a2494b14111d50b7b2
user: Sebastian Kaspari <s.kaspari@gmail.com>
date: Thu Jul 23 13:27:28 2015 +0200
description:
Bug 1186532 - Add RecyclerView library to Robocop builds. r=jonalmeida
|
||
Comment 9•9 years ago
|
||
|
||
Comment 10•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•