Closed
Bug 1186558
Opened 10 years ago
Closed 10 years ago
Upgrade bootstrap to 3.3.5
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
The new version fixes a bug with tooltips where they would inherit a bold property, which is important for bug 1186228 (where I want to add a tooltip to a bold span and have it look right).
| Assignee | ||
Comment 1•10 years ago
|
||
Did some testing with this, noticed only minor changes in some of the padding between buttons on the main screen (imperceptible unless you're switching back & forth between tabs)
I also removed the (unused) minified copy of the bootstrap js
Attachment #8637385 -
Flags: review?(tojonmz)
Comment 2•10 years ago
|
||
I'll do a moztrap run with this update tomorrow and report back.
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
Comment on attachment 8637385 [details] [review]
PR
r+ with the following pieces tweaked, mentioned in greater detail the PR:
(needed)
o add needed .woff2 glyphicons font resource file
o add our own .navbar-right margin-right to not truncate the RH navbar contents
(optional)
o add our own .checkbox min-height property for Similar Jobs
To be checked after push to stage with stage vs. prod comparison
o Exclusion profile panel appearance
Moztrap run
https://moztrap.mozilla.org/runtests/run/7661/env/27938/
Attachment #8637385 -
Flags: review?(tojonmz) → review+
Comment 4•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/de99cbb374b5e62969a611b359f8dbef3d5403f1
Bug 1186558 - Upgrade bootstrap to v3.3.5
This fixes display of tooltips in the perfherder compare view. Made some
minor tweaks to keep layout consistent with how it was before.
| Assignee | ||
Comment 5•10 years ago
|
||
Thanks for the help verifying this Jonathan! Merged with the suggested changes.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•