1186579 - TypeError: aEvent.target is undefined when calling openUILink(kSupportUri, {});

Status: RESOLVED FIXED

(Calendar :: Lightning: SeaMonkey Integration, defect)

Description

[Philip Chee]

Error: TypeError: aEvent.target is undefined
Source file: chrome://communicator/content/utilityOverlay.js
Line: 1418

http://mxr.mozilla.org/comm-central/source/calendar/lightning/content/messenger-overlay-sidebar.js?rev=3fe65676c36b#238

236     // call backs for the opt-out bar
237     let cbLearnMore = function(aNotificationBar, aButton) {
238         openUILink(kSupportUri, {});
239         return true;
240     };

SeaMonkey (and Firefox) expect that the second parameter is a real event or null.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 proposed fix.

Alternatives:
openUILink(kSupportUri, { button: 0, target: { ownerDocument: document } });
openUILink(kSupportUri, openUILink.length < 3 ? {} : null);

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8637422 [details] [diff] [review]
Patch v1.0 proposed fix.

Review of attachment 8637422 [details] [diff] [review]:
-----------------------------------------------------------------

What release do you need this for?

r=philipp with this nit:

::: calendar/lightning/content/messenger-overlay-sidebar.js
@@ +239,5 @@
> +        // In Thunderbird the number of formal parameters is 2.
> +        if (openUILink.length < 3)
> +          openUILink(kSupportUri, { button: 0 });
> +        else
> +          openUILink(kSupportUri); // SeaMonkey

I think it would be better to differ using xul app info, or just initiate a real Event and pass that unconditionally.

If you go for the first solution, brackets even for one-line ifs.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

(In reply to Philip Chee from comment #1)
This one is fine with me too:

> openUILink(kSupportUri, { button: 0, target: { ownerDocument: document } });

Comment 4

[Philip Chee]

Attachment: Patch v1.1 use event-like object r=Fallen Patch as checked-in

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/4edff7a7b2fa