1186658 - Handle XEP-0092: jabber:iq:version

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Comment 1

[aleth [:aleth]]

"Querying Another Entity for its Software Version". Used e.g. by the Slack XMPP gateway on connection.

Comment 2

[aleth [:aleth]]

We shouldn't send the OS, but imho we can send the app name and probably the version, as we do for IRC.

Comment 3

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 1 - handle version request

(In reply to aleth [:aleth] from comment #2)
> We shouldn't send the OS, but imho we can send the app name and probably the
> version, as we do for IRC.

If it's OK, this patch is ready for review.

Comment 4

[aleth [:aleth]]

Comment on attachment 8638958 [details] [diff] [review]
rev 1 - handle version request

Review of attachment 8638958 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Please make a note in the service discovery bug to implement section 4 of xep-0092.

::: chat/protocols/xmpp/xmpp.jsm
@@ +1230,5 @@
> +        children.push(Stanza.node("version", null, null,
> +                                  Services.appinfo.version));
> +        let versionQuery = Stanza.node("query", Stanza.NS.version, null,
> +                                       children);
> +        this.sendStanza(Stanza.iq("result", aStanza.attributes["id"],

Can we move aStanza.attributes["id"] and "from" into local variables at the beginning of the "get" if clause to reduce duplication? All responses to IQ stanzas will need them.

Comment 5

[Florian Quèze [:florian]]

(In reply to aleth [:aleth] from comment #2)
> We shouldn't send the OS, but imho we can send the app name and probably the
> version, as we do for IRC.

Seems OK to me. Especially if we already do it on IRC. Let's not send the build id though.

Comment 6

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 2 - handle version request

Comment 7

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/878a4890c96ad20db551abcd65fa2af6d6170da1
Bug 1186658 - Handle received version request and reply in XMPP. r=aleth