1186679 - thunderbird release builds should use mozilla- repo path not comm- repo path

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Jordan Lund (:jlund)]

+++ This bug was initially created as a clone of Bug #1186678 +++

e.g. http://ftp.mozilla.org/pub/mozilla.org/thunderbird/candidates/40.0b1-candidates/build1/logs/release-comm-beta-macosx64_build-bm86-build1-build3.txt.gz

bash -c 'python archiver_client.py mozharness --repo releases/comm-beta --tag THUNDERBIRD_40_0b1_RELEASE --debug'

the above releases/comm-beta should be releases/mozilla-beta

Comment 1

[Jordan Lund (:jlund)]

Attachment: 150722_bug_1186679_use_mozilla_repo_path_for_tb_release.patch

looks like I patched all the ScriptFactory release based factories but again I neglected to address the TB case for ReleaseBuildFactory (MercurialBuildFactory).

Comment 2

[Jordan Lund (:jlund)]

(In reply to Jordan Lund (:jlund) from comment #1)
> Created attachment 8637713 [details] [diff] [review]
> 150722_bug_1186679_use_mozilla_repo_path_for_tb_release.patch
> 
> looks like I patched all the ScriptFactory release based factories but again
> I neglected to address the TB case for ReleaseBuildFactory
> (MercurialBuildFactory).

dump_master diff: http://people.mozilla.org/~jlund/tb_release_mozilla_repo_path-dump_master.diff

(granted I only had 'comm-beta' in my master_config.json's 'thunderbird_release_branches' and all ff branches in the rest of master_config.json lists)

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 8637713 [details] [diff] [review]
150722_bug_1186679_use_mozilla_repo_path_for_tb_release.patch

lgtm

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8637713 [details] [diff] [review]
150722_bug_1186679_use_mozilla_repo_path_for_tb_release.patch

thanks

remote:   https://hg.mozilla.org/build/buildbotcustom/rev/bfe0b68213ee

Comment 5

[Jordan Lund (:jlund)]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/bfe0b68213ee

Comment 6

[[e-mail] (:bhearsum)]

This patch appears to have worked; retriggered builds have gotten past the mozharness step.