Skip AllocateAudioBlock() allocations known to be unnecessary.

RESOLVED FIXED in Firefox 42

Status

()

Core
Web Audio
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: karlt, Unassigned)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Comment 1

3 years ago
Created attachment 8637725 [details] [diff] [review]
skip reallocation when audio block is not shared

This takes the simple win.  It doesn't know when downstream nodes are no
longer using the buffer, but this is enough to skip about a quarter of these
allocations in a mochitest run and on
http://webaudiodemos.appspot.com/MIDIDrums/index.html
Attachment #8637725 - Flags: review?(padenot)

Updated

3 years ago
Attachment #8637725 - Flags: review?(padenot) → review+
https://hg.mozilla.org/mozilla-central/rev/08180ddf47e5
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.