Closed Bug 1186781 Opened 10 years ago Closed 10 years ago

Skip AllocateAudioBlock() allocations known to be unnecessary.

Categories

(Core :: Web Audio, defect)

Product:
Core
Component:
Web Audio
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: karlt, Unassigned)

Details

Attachments

(1 file)

skip reallocation when audio block is not shared
2.55 KB, patch
padenot
: review+
Details | Diff | Splinter Review
No description provided.
This takes the simple win. It doesn't know when downstream nodes are no longer using the buffer, but this is enough to skip about a quarter of these allocations in a mochitest run and on http://webaudiodemos.appspot.com/MIDIDrums/index.html
Attachment #8637725 - Flags: review?(padenot)
Attachment #8637725 - Flags: review?(padenot) → review+
https://hg.mozilla.org/mozilla-central/rev/08180ddf47e5
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: