1186842 - Unresponsive keyboard buttons using a PDF file

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Reproducible on: Firefox 42.0a1, Firefox 41.0a2 and Firefox 40.0b6 under Windows and Ubuntu 

STR
1. Start Firefox.
2. Open a PDF file (e.g. http://cp.literature.agilent.com/litweb/pdf/5989-8139EN.pdf )
3. Click a few times on the "Next page" button from the upper side of the document.
4. Press the “END” keyboard button.
5. Press any other keyboard button.

ER
The keyboard buttons are functional.

AR
The keyboard buttons are unresponsive, nothing happens when they are pressed.

Additional notes:
- This issue is reproducible on Firefox 42.0a1 (2015-07-22), Firefox 41.0a2 (2015-07-22) and Firefox 40 Beta 6 (20150720220238) under Windows 8.1 32-bit, Windows 7 64-bit and Ubuntu 14.04 32-bit.
- Mac platform is not affected.
- This issue is also reproducible on Firefox 35.
- In Firefox 19 the “END”/”HOME” buttons do not work until the focus is moved to the document, so this version is not affected.

Comment 1

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

[Tracking Requested - why for this release]: I think we might want this fixed as soon as possible, as the user impact would be pretty serious with keyboard navigation not working in PDFs.

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

Given that this issue has been around for a while (reproduces in Firefox 35), I don't think it's critical that we fix this in 40. Given that there is a fix, we should see about getting it into Firefox 41. I'm tracking 41 but not 40.

Jonas - I'd like to determine if this fix will be picked up in Firefox 41. How can I tell in which version of pdf.js this fix is included?

Comment 3

[Jonas Jenwald [:Snuffleupagus]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #2)
> Jonas - I'd like to determine if this fix will be picked up in Firefox 41.
> How can I tell in which version of pdf.js this fix is included?

This landed just *two* days ago upstream, so it isn't on mozilla-central yet. The fix is present in PDF.js version 1.1.334 and above.

Usually PDF.js is updated on mozilla-central during the week before an uplift, so I'd assume that the fix will be included in Firefox 42 (based on the dates in https://wiki.mozilla.org/RapidRelease/Calendar#Future_branch_dates).

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Florin, would it possible to verify the fix on FF41 and FF42? Thanks.

Comment 5

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Marking for verification. Note though that this was fixed by bug 1188344 which only landed in Firefox 42. We would need that fix in Firefox 41 as well to fix this.

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Pinged RyanVM and Wes to help uplift relevant changes to pdf.js in FF41 branch.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Jonas, can you post an uplift-ready patch and request approval for Beta41?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Fixed by the Fx41-specific patch in bug 1188344.

Comment 9

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 40 Beta 9 (20150730171029) under Windows 7 64-bit.

Verified fixed on Firefox 41 Beta 4 (20150824144923) and Firefox 42.0a2 (2015-08-24) under Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5.

Comment 10

[Vasilica Tamas, QA [:vtamas]]

Encountered this issue on Firefox 38.5.0 ESR (20151210074901) under Windows 7 64-bit and Ubuntu 14.04 32-bit.