1186849 - "File not found" issue when running "unregister-controller.https.html" test

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Noemí Freire (:noemi)]

Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/unregister-controller.https.html|

Actual Result:
"File not found"
Firefox can't find the file at https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/scope/no-new-controllee-even-if-registration-is-still-used.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

This bug can be closed once Bug 1201632 is fixed as that automatically fixes this test.

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1186849 - Update web-platform-tests expected data. r?jgraham

Bug 1186849 - Update web-platform-tests expected data. r?jgraham

Comment 3

[Noemí Freire (:noemi)]

Patch provided by Nikhil so assigning this to him. Please feel free to change it as needed. Thanks!

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

This is still a valid review.

Comment 5

[James Graham [:jgraham]]

Comment on attachment 8658430 [details]
MozReview Request: Bug 1186849 - Update web-platform-tests expected data. r?jgraham

https://reviewboard.mozilla.org/r/18597/#review17243

AFAICt this file is alrady gone a

Comment 6

[James Graham [:jgraham]]

https://reviewboard.mozilla.org/r/18597/#review17243

Sorry, I was having browser issues. The comment was supposed to read "AFAICT this file is already gone in the latest mozilla-inbound after the wpt upgrade".

Comment 7

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

expectation data has already been updated per comment 6.

Comment 8

[Noemí Freire (:noemi)]

Hi,

Just checked in m-c (3e8dde8f8c17 revision) and the tests successfully run:

Summary

Harness status: OK

Found 3 tests
3 Pass
Details
Result	Test Name
Pass	Unregister does not affect existing controller	
Pass	Unregister prevents control of subsequent navigations	
Pass	Unregister prevents new controllee even if registration is still in use	

but an error message is shown "{"error": {"message": "", "code": 404}}", traces available at https://pastebin.mozilla.org/8846542 (ni to Nikhil). Thanks!

Comment 9

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

(In reply to Noemí Freire (:noemi) from comment #8)
> Hi,
> 
> Just checked in m-c (3e8dde8f8c17 revision) and the tests successfully run:
> 
> Summary
> 
> Harness status: OK
> 
> Found 3 tests
> 3 Pass
> Details
> Result	Test Name
> Pass	Unregister does not affect existing controller	
> Pass	Unregister prevents control of subsequent navigations	
> Pass	Unregister prevents new controllee even if registration is still in use	
> 
> but an error message is shown "{"error": {"message": "", "code": 404}}",
> traces available at https://pastebin.mozilla.org/8846542 (ni to Nikhil).
> Thanks!

Yes that is because the test loads iframes that don't actually exist, only for the side-effect of firing onload. See bug 1201632.