1186857 - "File not found" issue when running "unregister-then-register.https.html" test

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Noemí Freire (:noemi)]

Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/unregister-then-register.https.html|

Actual Result: 3 "File not found" issues
1- Firefox can't find the file at https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/scope/re-register-does-not-affect-existing-controllee.
2- Firefox can't find the file at https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/scope/re-register-while-old-registration-in-use.
3- Firefox can't find the file at https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/scope/resurrection.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r=jgraham

Bug 1186857 - Update web-platform-tests expected data. r?jgraham

Comparing scopes for now, added a note to Bug 1201127 to fix this.

Comment 2

[Noemí Freire (:noemi)]

Patch provided by Nikhil so assigning this to him. Please feel free to change it as needed. Thanks!

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

This one is also still valid

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8658440 [details]
MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r=jgraham

https://reviewboard.mozilla.org/r/18601/#review17251

::: testing/web-platform/mozilla/tests/service-workers/service-worker/unregister-then-register.https.html:51
(Diff revision 1)
> -          assert_equals(registration, new_registration,
> +          assert_equals(registration.scope, new_registration.scope,

I don't understand this change. It seems like either the text of the assert is misleading or the test has been changed to be wrong. Is the registration object supposed to be the same in each case per spec? It looks like it is, but I haven't read it in detail. If so the test was correct before. If not the assert text needs to explain what is actually expected.

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8658440 [details]
MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r=jgraham

Bug 1186857 - Update web-platform-tests expected data. r?jgraham

Comparing scopes for now, added a note to Bug 1201127 to fix this.

Comment 6

[James Graham [:jgraham]]

Comment on attachment 8658440 [details]
MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r=jgraham

https://reviewboard.mozilla.org/r/18601/#review17319

OK, per conversation on irc, but please at least file a bug to create a test covering the registration object equality before landing this.

Comment 7

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8658440 [details]
MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r=jgraham

Bug 1186857 - Update web-platform-tests expected data. r=jgraham

Comparing scopes for now, added a note to Bug 1201127 to fix this.

Comment 8

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9751d5e495b9

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/156b6847bbb4

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for w(4) bustage
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab174fa288a3

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=14277612&repo=mozilla-inbound

Comment 12

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e8dd2742625a606946026babc82478765ed51de
Bug 1186857 - Update web-platform-tests expected data. r=jgraham

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4e8dd2742625

Comment 14

[Noemí Freire (:noemi)]

Hi,

just checked in m-c (6227054b7811 revision) and the tests successfully run. Thanks for fixing it!.

Summary

Harness status: OK

Found 4 tests
4 Pass
Details
Result	Test Name
Pass	Unregister then register resolves to a new value	
Pass	Unregister then register resolves to the original value if the registration is in use.	
Pass	Unregister then register does not affect existing controllee	
Pass	Unregister then register resurrects the registration