"File not found" issue when running "unregister-then-register.https.html" test

RESOLVED FIXED in Firefox 43

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: noemi, Assigned: nsm)

Tracking

Trunk
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 affected, firefox43 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

4 years ago
Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/unregister-then-register.https.html|

Actual Result: 3 "File not found" issues
1- Firefox can't find the file at https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/scope/re-register-does-not-affect-existing-controllee.
2- Firefox can't find the file at https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/scope/re-register-while-old-registration-in-use.
3- Firefox can't find the file at https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/scope/resurrection.
Reporter

Updated

4 years ago
Component: DOM: Service Workers → web-platform-tests
Product: Core → Testing
Bug 1186857 - Update web-platform-tests expected data. r?jgraham

Comparing scopes for now, added a note to Bug 1201127 to fix this.
Attachment #8658440 - Flags: review?(james)
Reporter

Comment 2

4 years ago
Patch provided by Nikhil so assigning this to him. Please feel free to change it as needed. Thanks!
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
This one is also still valid
Flags: needinfo?(james)
Comment on attachment 8658440 [details]
MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r=jgraham

https://reviewboard.mozilla.org/r/18601/#review17251

::: testing/web-platform/mozilla/tests/service-workers/service-worker/unregister-then-register.https.html:51
(Diff revision 1)
> -          assert_equals(registration, new_registration,
> +          assert_equals(registration.scope, new_registration.scope,

I don't understand this change. It seems like either the text of the assert is misleading or the test has been changed to be wrong. Is the registration object supposed to be the same in each case per spec? It looks like it is, but I haven't read it in detail. If so the test was correct before. If not the assert text needs to explain what is actually expected.
Attachment #8658440 - Flags: review?(james)
Flags: needinfo?(james)
Comment on attachment 8658440 [details]
MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r=jgraham

Bug 1186857 - Update web-platform-tests expected data. r?jgraham

Comparing scopes for now, added a note to Bug 1201127 to fix this.
Attachment #8658440 - Flags: review?(james)
Comment on attachment 8658440 [details]
MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r=jgraham

https://reviewboard.mozilla.org/r/18601/#review17319

OK, per conversation on irc, but please at least file a bug to create a test covering the registration object equality before landing this.
Attachment #8658440 - Flags: review?(james) → review+
Attachment #8658440 - Attachment description: MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r?jgraham → MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r=jgraham
Comment on attachment 8658440 [details]
MozReview Request: Bug 1186857 - Update web-platform-tests expected data. r=jgraham

Bug 1186857 - Update web-platform-tests expected data. r=jgraham

Comparing scopes for now, added a note to Bug 1201127 to fix this.
Flags: needinfo?(nsm.nikhil)
https://hg.mozilla.org/mozilla-central/rev/4e8dd2742625
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Reporter

Comment 14

4 years ago
Hi,

just checked in m-c (6227054b7811 revision) and the tests successfully run. Thanks for fixing it!.

Summary

Harness status: OK

Found 4 tests
4 Pass
Details
Result	Test Name
Pass	Unregister then register resolves to a new value	
Pass	Unregister then register resolves to the original value if the registration is in use.	
Pass	Unregister then register does not affect existing controllee	
Pass	Unregister then register resurrects the registration
You need to log in before you can comment on or make changes to this bug.