keyboard.is_keyboard_displayed is always returning true in current builds

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Martijn Wargers (zombie), Assigned: Martijn Wargers (zombie))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Follow-up from bug 1186462.

See http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py#442
Because inputwindow gets class called 'inactive' when it's not active anymore. Quite obvious that this check doesn't work.

I think we should check for like is done in dismiss():
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py#343
Created attachment 8637993 [details] [review]
[gaia] mwargers:1186893 > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8637993 [details] [review]
[gaia] mwargers:1186893 > mozilla-b2g:master

In my opinion, I think only the input_window.is_displayed() part would be enough. 
I don't think the (int(input_window.location['y']) == expected_y) part is necessary, either.
Attachment #8637993 - Flags: review?(npark)
Attachment #8637993 - Flags: review?(jlorenzo)
Comment on attachment 8637993 [details] [review]
[gaia] mwargers:1186893 > mozilla-b2g:master

r+ assuming the comments I made in the pull requests are non-issue.
Attachment #8637993 - Flags: review?(npark) → review+
(Assignee)

Updated

3 years ago
Blocks: 1187015
Comment on attachment 8637993 [details] [review]
[gaia] mwargers:1186893 > mozilla-b2g:master

This refactor looks great!
Attachment #8637993 - Flags: review?(jlorenzo) → review+
(Assignee)

Updated

3 years ago
Blocks: 1184952
(Assignee)

Comment 5

3 years ago
Merged: https://github.com/mozilla-b2g/gaia/commit/c0c218fe20ff4d07a7dd8777ea7d6835c89d663b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
No longer blocks: 1184952
Duplicate of this bug: 1184952
You need to log in before you can comment on or make changes to this bug.