Closed
Bug 1186893
Opened 9 years ago
Closed 9 years ago
keyboard.is_keyboard_displayed is always returning true in current builds
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
()
Details
Attachments
(1 file)
Follow-up from bug 1186462. See http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py#442 Because inputwindow gets class called 'inactive' when it's not active anymore. Quite obvious that this check doesn't work. I think we should check for like is done in dismiss(): http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py#343
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8637993 [details] [review] [gaia] mwargers:1186893 > mozilla-b2g:master In my opinion, I think only the input_window.is_displayed() part would be enough. I don't think the (int(input_window.location['y']) == expected_y) part is necessary, either.
Attachment #8637993 -
Flags: review?(npark)
Attachment #8637993 -
Flags: review?(jlorenzo)
Comment 3•9 years ago
|
||
Comment on attachment 8637993 [details] [review] [gaia] mwargers:1186893 > mozilla-b2g:master r+ assuming the comments I made in the pull requests are non-issue.
Attachment #8637993 -
Flags: review?(npark) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8637993 [details] [review] [gaia] mwargers:1186893 > mozilla-b2g:master This refactor looks great!
Attachment #8637993 -
Flags: review?(jlorenzo) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/c0c218fe20ff4d07a7dd8777ea7d6835c89d663b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•