Closed Bug 1186979 Opened 9 years ago Closed 8 years ago

Long press back/forward list

Categories

(Firefox for iOS :: Browser, defect)

Product:
Firefox for iOS
Component:
Browser
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 5.0+ ---
fxios-v5.0 --- fixed

People

(Reporter: bnicholson, Assigned: tecgirl)

References

Details

Attachments

(1 file)

https://github.com/mozilla/firefox-ios/pull/1840
48 bytes, text/x-github-pull-request
sleroux
: review+
sleroux
: feedback+
Details | Review
We should show a list of history entries when the user long-presses the back/forward buttons. This didn't make v1 since we didn't have UX mockups. I think tecgirl wants to look into this now, so we can start work for v1.1.
I'd like to work on this feature. tecgirl, let me know when we can start working on this one.
Flags: needinfo?(randersen)
Flags: needinfo?(randersen)
Assignee: nobody → kbenhmida
Assignee: benhmida.k+bz → randersen
Status: NEW → ASSIGNED
Rank: 2
tracking-fxios: 2.0+ → +
Comment on attachment 8755880 [details] [review] https://github.com/mozilla/firefox-ios/pull/1840 I think this is a good start but I'd like to see this approached a bit differently from the code side of things. I've left some comments on the PR but let's get together and jam on this for a bit.
Attachment #8755880 - Flags: feedback+
Went over the revised changes and it's looking really good. Couple nits and questions. We should also consider using the UIViewController presentation API instead of adding the view directly.
Comment on attachment 8755880 [details] [review] https://github.com/mozilla/firefox-ios/pull/1840 Awesome work - this feels great. Just one last comment and I think we're good to go.
Attachment #8755880 - Flags: review?(sleroux) → review+
(In reply to Stephan Leroux [:sleroux] from comment #6) > Comment on attachment 8755880 [details] [review] > https://github.com/mozilla/firefox-ios/pull/1840 > > Awesome work - this feels great. Just one last comment and I think we're > good to go. Awesome! Thanks Steph! I made the change. :)
master 6d1eefbc749673d696052f98a610994248d2c266
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [needsuplift]
v5.x 08b8b99e4356d24817f887ca116d82ed0997bd5b
status-fxios-v5.0: --- → fixed
Whiteboard: [needsuplift]
Depends on: 1289893
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: