Closed Bug 1186979 Opened 6 years ago Closed 5 years ago
Long press back/forward list
We should show a list of history entries when the user long-presses the back/forward buttons. This didn't make v1 since we didn't have UX mockups. I think tecgirl wants to look into this now, so we can start work for v1.1.
I'd like to work on this feature. tecgirl, let me know when we can start working on this one.
Comment on attachment 8755880 [details] [review] https://github.com/mozilla/firefox-ios/pull/1840 I think this is a good start but I'd like to see this approached a bit differently from the code side of things. I've left some comments on the PR but let's get together and jam on this for a bit.
Attachment #8755880 - Flags: feedback+
Went over the revised changes and it's looking really good. Couple nits and questions. We should also consider using the UIViewController presentation API instead of adding the view directly.
Comment on attachment 8755880 [details] [review] https://github.com/mozilla/firefox-ios/pull/1840 Round 2 feedback
Comment on attachment 8755880 [details] [review] https://github.com/mozilla/firefox-ios/pull/1840 Awesome work - this feels great. Just one last comment and I think we're good to go.
Attachment #8755880 - Flags: review?(sleroux) → review+
(In reply to Stephan Leroux [:sleroux] from comment #6) > Comment on attachment 8755880 [details] [review] > https://github.com/mozilla/firefox-ios/pull/1840 > > Awesome work - this feels great. Just one last comment and I think we're > good to go. Awesome! Thanks Steph! I made the change. :)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.