1187011 - Response constructor should throw if body provided, but status code does not permit a body

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

https://github.com/whatwg/fetch/issues/86

Comment 1

[Josh Matthews [:jdm]]

Relevant code here is dom/fetch/Response.cpp in the static Constructor method.

Comment 2

[Sai Sandeep [:mprsai]]

I'm working on it

Comment 3

[Miko Mynttinen]

Attachment: Dont allow body with null body status

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8666872 [details] [diff] [review]
Dont allow body with null body status

Review of attachment 8666872 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!  Just one nit to fix.  r=me with that addressed.  Thanks!

::: dom/tests/mochitest/fetch/test_response.js
@@ +201,5 @@
>      });
>    })
>  }
>  
> +function testBug1187011() {

nit: Can you name this function something like testNullBodyStatus() instead of using the bug number?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Also, can you push a try build?

Comment 6

[Miko Mynttinen]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e384dcebc28b

Comment 7

[Miko Mynttinen]

Attachment: Don't allow response body with null body status

Comment 8

[Miko Mynttinen]

Comment on attachment 8668035 [details] [diff] [review]
Don't allow response body with null body status

Thank you for the review. Here is the change you requested.

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8668035 [details] [diff] [review]
Don't allow response body with null body status

Review of attachment 8668035 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e407fe41dcd

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1e407fe41dcd