Closed Bug 1187054 Opened 9 years ago Closed 9 years ago

v4 totalTime not binned by subsession

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: bcolloran, Unassigned)

References

Details

See the notebook here--
https://gist.github.com/bcolloran/323eeea11de94ca8b2dc
-- it appears that totalTime appears to increase monotonically from one subsession to the next within a client session (but activeTicks does not, it just looks crazy). This behavior is not correct; in both cases, the value recorded for activeTicks and totalTime should be the value for that subsession only, not the cumulative total for the entire client session.

The reason for this is that when a client session is split across days or environment change, we want to know the time spent in each day, or in each environment state without having to find a previous ping and subtract. The values collected in the subsession bins should be non-overlapping so that they can be aggregated without risk of double counting.

The same applies to e.g. search, crashes, basically anything else that happens in time-- it must be assigned to a subsession so that we can aggregate by environment, date, client, etc without double counting.
Blocks: 1186713
Note that my first guess is that I'm looking at the wrong field. Is there a field that records the time per subsession? (If so, the v2/v4 data equivalents spreadsheet should be updated with that field).
Flags: needinfo?(gfritzsche)
Flags: needinfo?(alessio.placitelli)
Yes, |totalTime| tracks the time spent in the whole session, is not reset on subsession changes.

We do have the |subsessionLength| field [1], which tracks the subsession length in seconds. Is this what you were looking for?

[1] - https://ci.mozilla.org/job/mozilla-central-docs/Tree_Documentation/toolkit/components/telemetry/telemetry/main-ping.html
Flags: needinfo?(alessio.placitelli)
Flags: needinfo?(gfritzsche)
Flags: needinfo?(bcolloran)
Thanks guys, that was the problem, very helpful. I added a note to the v2/v4 equivalency sheet.

Still some more things to look into, but on the right track now at least.

https://gist.github.com/bcolloran/f79914990e88da62eeaa
Flags: needinfo?(bcolloran)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Thought i'd close this one as the original question is resolved, lets file new bugs on other specific problems found?
Sure, sounds good.
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.