Closed Bug 1187059 Opened 9 years ago Closed 9 years ago

change the header to use light font weight on about:logins

Categories

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

Product:
Firefox for Android Graveyard
Component:
Logins, Passwords and Form Fill
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: ally, Assigned: ally)

Details

Attachments

(2 files, 3 obsolete files)

tmp_11933-Screenshot_2015-07-24-15-44-16-741635655.png
64.39 KB, image/png
antlam
: review+
Details
aboutLoginsChangeTextWeight
667 bytes, patch
liuche
: review+
Details | Diff | Splinter Review
currently about:logins derives its header class from the base.css. Anthony would like ti have a lighter weight across all the pages (loading, content, edit, empty etc) in about:logins
Assignee: nobody → ally
Attached image Screenshot_2015-07-23-17-45-01.png (obsolete) —
Attached image Screenshot_2015-07-23-17-44-56.png (obsolete) —
Anthony are you sure you want this light weight for the headers?!
Flags: needinfo?(alam)
Hey Ally, I was just referring to the empty state's titles. Though, what is the cost associated in this case? If the overhead is large, it might not be worth it right now. I misunderstood and thought it was a weight we had already supported.
Flags: needinfo?(alam) → needinfo?(ally)
cost is minimal. the explicit setting wasnt working.
Flags: needinfo?(ally)
Text in light weight on nexus 9
Attachment #8638796 - Flags: review?(alam)
Comment on attachment 8638796 [details] tmp_11933-Screenshot_2015-07-24-15-04-55-309381155.png Sorry Ally! Weren't we talking about just the header?
Attachment #8638796 - Flags: review?(alam) → review-
"Keep your logins safe"
(In reply to Anthony Lam (:antlam) from comment #7) > "Keep your logins safe" (In reply to Anthony Lam (:antlam) from comment #6) > Comment on attachment 8638796 [details] > tmp_11933-Screenshot_2015-07-24-15-04-55-309381155.png > > Sorry Ally! Weren't we talking about just the header? Since you said 'titles' in "Hey Ally, I was just referring to the empty state's titles." I thought you meant both. Ill modify the patch. Do I need a screenshot for that too, or are you reasonably content with the above?
Flags: needinfo?(alam)
Flags: needinfo?(alam)
I decided you were getting one anyway. ☺
Attachment #8638243 - Attachment is obsolete: true
Attachment #8638244 - Attachment is obsolete: true
Attachment #8638796 - Attachment is obsolete: true
Attachment #8638814 - Flags: review?(alam)
Attachment #8638816 - Flags: review?(liuche)
Comment on attachment 8638814 [details] tmp_11933-Screenshot_2015-07-24-15-44-16-741635655.png Looks good, Ally! thanks!
Attachment #8638814 - Flags: review?(alam) → review+
Attachment #8638816 - Attachment is patch: true
Comment on attachment 8638816 [details] [diff] [review] aboutLoginsChangeTextWeight Review of attachment 8638816 [details] [diff] [review]: ----------------------------------------------------------------- Nice. Remember to mark this as a patch so it can be reviewed in Splinter - I've needed to check that box myself a couple of times.
Attachment #8638816 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/819c7da861a2
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: