1187171 - TabManager.storeChanges called twice during restore

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Description

[Richard Newman [:rnewman]]

This ultimately hits the DB twice as much as necessary.

Comment 1

[Richard Newman [:rnewman]]

Ah. It's actually called once per entry in history during restore!

    func webView(webView: WKWebView, didFinishNavigation navigation: WKNavigation!) {
        hideNetworkActivitySpinner()
        storeChanges()
    }

And even then it's wrong, seemingly missing history.

Comment 2

[Aaron Train [:aaronmt]]

Culprit of slow startup? Ought to track, no?

Comment 3

[Richard Newman [:rnewman]]

Triage explanation: plus for this because it affects startup. Not plus for Bug 1187176, even though we'd love a fix.

Comment 4

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 5

[Stephan Leroux [:sleroux]]

Comment on attachment 8642940 [details] [review]
Pull request

Fixes look good but left a comment on resolving the issue pointed out in this bug.

Comment 6

[Emily Toop (:fluffyemily)]

I think the issue with storeChanges() getting called too often overall and the fact that storeChanges() is pretty heavy in it's implementation (delete all tabs from the db, create them all again AND write tabs to disk) will all come under https://bugzilla.mozilla.org/show_bug.cgi?id=1187176 with this one being purely about slow startup performance