Closed Bug 1187173 Opened 6 years ago Closed 6 years ago

Warning C4623 on ExtendedValidation.cpp blocks compilation with warnings-as-errors enabled

Categories

(Core :: Security: PSM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

The error message is:
> central/security/certverifier/ExtendedValidation.cpp(34): error C2220: warning treated as error - no 'object' file generated
> central/security/certverifier/ExtendedValidation.cpp(34): warning C4623: 'nsMyTrustedEVInfo': default constructor was implicitly defined as d
eleted because a base class default constructor is inaccessible or deleted
> central\security\certverifier\CNNICHashWhitelist.inc(16): warning C4623: 'WhitelistedCNNICHash': default constructor was implicitly defined a
s deleted because a base class default constructor is inaccessible or deleted
Attached patch patchSplinter Review
Attachment #8638279 - Flags: review?(brian)
Comment on attachment 8638279 [details] [diff] [review]
patch

Review of attachment 8638279 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8638279 - Flags: review?(brian) → review+
Component: Security → Security: PSM
https://hg.mozilla.org/mozilla-central/rev/68d8910a9cc3
Assignee: nobody → quanxunzhen
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.