Closed
Bug 1187309
Opened 9 years ago
Closed 9 years ago
Simplify the workaround for detecting systems with microphone and no audio, and drop unnecessary 1500 exceptions
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox42 verified)
Tracking | Status | |
---|---|---|
firefox42 | --- | verified |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
Now we're logging exceptions, we're seeing a lot of 1500 exceptions from the sdk (unable to publish). We could be getting these from multiple causes, but one cause I do know that's giving false alerts is if a user has only a microphone on desktop. We currently attempt camera + microphone, and if that fails we fallback to just the microphone. This is because the sdk doesn't yet support the new mediaDevices API (Bug 1138851). This bug simplifies our workarounds so that the api they do support is simulated and based on mediaDevices. As this only affects in-browser users, we're fine using the new API to do this.
Comment 2•9 years ago
|
||
Comment on attachment 8638535 [details] [diff] [review] Simplify the no-camera work around for Loop that was put in place when we didn't have device enumeration - avoid unnecessary exceptions from the sdk. Review of attachment 8638535 [details] [diff] [review]: ----------------------------------------------------------------- Very nice simplification! With the change mentioned below, r=me. ::: browser/components/loop/content/shared/js/otSdkDriver.js @@ +78,5 @@ > + } > + > + var result = []; > + > + if (devices.some(hasAudio)) { I'm pretty sure that the 'some' use here has very little use here over simple one-time-iteration with forEach - IOW run one loop, not two: ```js var result = []; devices.forEach(function(device) { if (device.kind === "audioinput") { result.push("audio"); } else if (device.kind === "videoinput") { result.push("video"); } }); callback(result); ```
Attachment #8638535 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 4•9 years ago
|
||
For verification, this is all on the desktop side, link-clicker isn't affected. Verify that for both conversations via links, and direct calls via contacts: - No media devices (mic/video) gives appropriate message - Just a microphone allows a call to work - Video + Microphone works normally This also fixes bug 1158138, which I'll mark as a duplicate of this in a moment.
Flags: qe-verify+
Flags: firefox-backlog+
Priority: -- → P2
Updated•9 years ago
|
QA Contact: bogdan.maris
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/521c01986d01
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment 7•9 years ago
|
||
(In reply to Mark Banner (:standard8) (away until 24 Aug) from comment #4) > Verify that for both conversations via links, and direct calls via contacts: > > - No media devices (mic/video) gives appropriate message > - Just a microphone allows a call to work > - Video + Microphone works normally > > This also fixes bug 1158138, which I'll mark as a duplicate of this in a > moment. Verified that all this scenarios are working as they should on Windows 7 64-bit and Ubuntu 14.04 32-bit using latest Aurora 42.0a2.
You need to log in
before you can comment on or make changes to this bug.
Description
•